From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Valtteri Vuorikoski Newsgroups: gmane.emacs.bugs Subject: bug#64698: 29.0.92; on netbsd 9.3, gmake and "gmake bootstrap" fail to proceed Date: Fri, 21 Jul 2023 13:13:36 +0300 Message-ID: References: <202307180931.36I9VBHK004438@sdf.org> <87sf9l5xj9.fsf@yahoo.com> <83edl578r7.fsf@gnu.org> <202307190310.36J3ADWp017577@sdf.org> <837cqw5bho.fsf@gnu.org> <838rbb42ab.fsf@gnu.org> <83a5vq36kk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33222"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: NeoMutt/20230517-193-0143df-dirty Cc: luangruo@yahoo.com, van.ly@sdf.org, eggert@cs.ucla.edu, 64698@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 21 12:15:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qMnAS-0008QU-PH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jul 2023 12:15:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMnAB-0000Yd-RU; Fri, 21 Jul 2023 06:15:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMnA6-0000YH-Ul for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 06:15:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMnA6-0004CF-LX for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 06:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMnA6-0001QH-1h for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 06:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Valtteri Vuorikoski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jul 2023 10:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64698 X-GNU-PR-Package: emacs Original-Received: via spool by 64698-submit@debbugs.gnu.org id=B64698.16899344555392 (code B ref 64698); Fri, 21 Jul 2023 10:15:01 +0000 Original-Received: (at 64698) by debbugs.gnu.org; 21 Jul 2023 10:14:15 +0000 Original-Received: from localhost ([127.0.0.1]:60577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMn9K-0001Ou-Hc for submit@debbugs.gnu.org; Fri, 21 Jul 2023 06:14:14 -0400 Original-Received: from jkusti.notcom.org ([118.27.113.153]:37196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMn9H-0001Oj-T1 for 64698@debbugs.gnu.org; Fri, 21 Jul 2023 06:14:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=notcom.org; s=jk; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject: Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CIBZ3K4SPHB3Jhhkcqsn1qSXzNpYNrxWZMhCtZQoWIY=; t=1689934451; x=1690798451; b=QLlEGO8Mo4R5KX+2DO9kZ2ft5I+H+4hEr9oH3HOt/TXcUCbJMVc23XJWtrTFxMgbpE3emEbiHsV NueWwmfOsV7IYwHg6aDLFIwOmzVstq4muYCn2qhMgcGznPwZlV2WhN692p5YIHNBQAL4mFD7cDdaA LiPhirp9B7yP/w0A7Ue4B4WvR9/sEMz2d9OLgZioTz9XzKFiUbNIcrgzhGIhWH9LzXdB9DfSPcWtH CVqD1kypH3UW6WTWfeuN0hhALhasTChdAp10GAKmQYTEGfx3Fk1HiN7jGd4LnDYNOTeEKX8oiSWuB KpebO04dY8o2/MzG5Gz0y1DeiDiZhjnoZ7XA==; Original-Received: from submission.internal (id=9cdceae8c7b5bf2d4c2c643b5341fa4197f0c084) by jkusti.notcom.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.x) (envelope-from ) id 1qMn8w-003SFa-AI; Fri, 21 Jul 2023 10:13:50 +0000 Original-Received: from a10d750d756b015054aa81d63d047a232e64e839 by sendhost.internal with local (Exim 4.x) (envelope-from ) id 1qMn8p-006ZvP-B5; Fri, 21 Jul 2023 13:13:43 +0300 Content-Disposition: inline In-Reply-To: <83a5vq36kk.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265668 Archived-At: On Thu, Jul 20, 2023 at 07:12:43PM +0300, Eli Zaretskii wrote: > > Building emacs with sound enabled but alsa-lib _not_ installed seems > > to work (= compiles and starts) by using the system OSS library. Since > > Emacs's audio needs are modest, it may be better to use "bsd-ossaudio" > > on NetBSD if --with-sound=yes. AFAICT "ALSA" on NetBSD is just a proxy > > for the native audio system anyway. > > > > The other option is to try and use ALSA if --with-sound=yes, but > > #ifdef out the ESTRPIPE branch if ESTRPIPE is not defined. > > > > Personally I'd go with the default-to-ossaudio option, since pulling in > > alsa libraries introduces a pkgsrc dependency into the binary and doesn't > > seem like it provides a lot of benefit. I'm not quite sure what's the > > best way to convince configure.ac to act like this, but I can test > > patches at least on a compiles/doesn't-compile level. > > Thanks. I went with the #ifdef approach on the release branch, since > it's simpler and therefore safer. > > Patches are welcome for preferring bsd-ossaudio on NetBSD. If you want to apply it for -30, this basically implements the suggestion that was already dnl'd in configure.ac. Emacs will end up using ossaudio even if the alsa-lib pkgsrc package is installed. --- a/configure.ac +++ b/configure.ac @@ -1797,8 +1797,10 @@ AC_DEFUN AC_CHECK_LIB([ossaudio], [_oss_ioctl], [LIBSOUND=-lossaudio], [LIBSOUND=]) test "${with_sound}" = "bsd-ossaudio" && test -z "$LIBSOUND" && \ AC_MSG_ERROR([bsd-ossaudio sound support requested but not found.]) - dnl FIXME? If we did find ossaudio, should we set with_sound=bsd-ossaudio? - dnl Traditionally, we go on to check for alsa too. Does that make sense? + # On NetBSD use the system audio library instead of potentially switching + # to ALSA later on, as ALSA on NetBSD appears to just wrap OSS. + test "${with_sound}" = "yes" && test "$LIBSOUND" = "-lossaudio" && \ + with_sound="bsd-ossaudio" fi AC_SUBST([LIBSOUND]) The emacs28 pkgsrc package doesn't set any sound-related configure flags. I assume they're building binary packages on an alsa-free system and have been happy with the result (= -lossaudio is used because no alsa). People who want alsa should be able to still get it with --with-sound=alsa. - Valtteri