From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sebastian Tennant Newsgroups: gmane.emacs.bugs Subject: bug#1973: Bug in simple.el (Emacs version 22.2.1) Date: Thu, 22 Jan 2009 14:00:26 +0000 Message-ID: References: <63k9n3fx.fsf@vps203.linuxvps.org> Reply-To: Sebastian Tennant , 1973@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1232634291 23544 80.91.229.12 (22 Jan 2009 14:24:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 22 Jan 2009 14:24:51 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 22 15:26:04 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LQ0Uo-0002l9-Bb for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Jan 2009 15:25:26 +0100 Original-Received: from localhost ([127.0.0.1]:52579 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LQ0TX-0001bv-2f for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Jan 2009 09:24:07 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LQ0Sz-0001C2-GD for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2009 09:23:33 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LQ0Sx-0001AW-Uk for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2009 09:23:33 -0500 Original-Received: from [199.232.76.173] (port=51807 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LQ0Sx-0001AL-5z for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2009 09:23:31 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:43620) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LQ0Sw-0001MY-BC for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2009 09:23:30 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0MENSMt001406; Thu, 22 Jan 2009 06:23:28 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n0ME54li029267; Thu, 22 Jan 2009 06:05:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Sebastian Tennant Original-Sender: news Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 22 Jan 2009 14:05:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 1973 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.123263274327223 (code B ref -1); Thu, 22 Jan 2009 14:05:04 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 22 Jan 2009 13:59:03 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0MDwvQC027215 for ; Thu, 22 Jan 2009 05:59:00 -0800 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LQ05B-0000rh-90 for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2009 08:58:57 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LQ059-0000qb-Dv for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2009 08:58:56 -0500 Original-Received: from [199.232.76.173] (port=36174 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LQ058-0000qL-7m for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2009 08:58:55 -0500 Original-Received: from main.gmane.org ([80.91.229.2]:45488 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LQ057-0006YR-LT for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2009 08:58:53 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1LQ053-0004wF-J5 for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2009 13:58:50 +0000 Original-Received: from vps203.linuxvps.org ([91.186.7.203]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 22 Jan 2009 13:58:49 +0000 Original-Received: from sebyte by vps203.linuxvps.org with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 22 Jan 2009 13:58:49 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 57 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: vps203.linuxvps.org User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.2 (gnu/linux) Cancel-Lock: sha1:7Jn3lJg+WSJ6vkbio1NIDvUi3ko= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 22 Jan 2009 09:23:32 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24387 Archived-At: --=-=-= Quoth Sebastian Tennant : > Asynchronous commands called via shell-command, for example: > > (shell-command "apt-get update &") > > fill the buffer *Async Shell Command Output* with Ctrl-Ms, which I'm > sure is not what's intended. > > My patch (attached) fixes this by using make-comint-in-buffer, rather > than start-process, to call the asynchronous process. Actually, this updated patch (attached) is what's required to fix the problem here. It explicitly puts the buffer in comint-mode. (My last patch neglected to do this). Sebastian --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=simple.el.diff --- /usr/share/emacs/22.2/lisp/simple.el~ 2009-01-21 15:12:12.502915265 +0000 +++ /usr/share/emacs/22.2/lisp/simple.el 2009-01-22 13:22:17.352984134 +0000 @@ -1889,13 +1889,14 @@ (error "Shell command in progress"))) (with-current-buffer buffer (setq buffer-read-only nil) - (erase-buffer) + (comint-mode) (erase-buffer) (display-buffer buffer) (setq default-directory directory) - (setq proc (start-process "Shell" buffer shell-file-name - shell-command-switch command)) + (setq proc (get-buffer-process + (make-comint-in-buffer + "Shell" buffer shell-file-name nil + shell-command-switch command))) (setq mode-line-process '(":%s")) - (require 'shell) (shell-mode) (set-process-sentinel proc 'shell-command-sentinel) )) (shell-command-on-region (point) (point) command --=-=-= -- Emacs' AlsaPlayer - Music Without Jolts Lightweight, full-featured and mindful of your idyllic happiness. http://home.gna.org/eap --=-=-=--