From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#16859: tty-setup-hook can run twice Date: Tue, 25 Feb 2014 17:24:38 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1393367102 6988 80.91.229.3 (25 Feb 2014 22:25:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Feb 2014 22:25:02 +0000 (UTC) Cc: 16859@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 25 23:25:09 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WIQR2-00006R-EZ for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Feb 2014 23:25:08 +0100 Original-Received: from localhost ([::1]:37318 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIQR1-0005hh-VS for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Feb 2014 17:25:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIQQy-0005bI-0W for bug-gnu-emacs@gnu.org; Tue, 25 Feb 2014 17:25:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WIQQx-00072S-Ar for bug-gnu-emacs@gnu.org; Tue, 25 Feb 2014 17:25:03 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIQQx-000724-7L for bug-gnu-emacs@gnu.org; Tue, 25 Feb 2014 17:25:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WIQQw-0003s5-K9 for bug-gnu-emacs@gnu.org; Tue, 25 Feb 2014 17:25:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Feb 2014 22:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16859 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16859-submit@debbugs.gnu.org id=B16859.139336708214851 (code B ref 16859); Tue, 25 Feb 2014 22:25:02 +0000 Original-Received: (at 16859) by debbugs.gnu.org; 25 Feb 2014 22:24:42 +0000 Original-Received: from localhost ([127.0.0.1]:40026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WIQQb-0003rS-EM for submit@debbugs.gnu.org; Tue, 25 Feb 2014 17:24:41 -0500 Original-Received: from fencepost.gnu.org ([208.118.235.10]:56278) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WIQQZ-0003rL-FF for 16859@debbugs.gnu.org; Tue, 25 Feb 2014 17:24:39 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WIQQY-00023o-Hw; Tue, 25 Feb 2014 17:24:38 -0500 X-Spook: USDOJ Skipjack bomb Armani Sears Tower SAFE satellite X-Ran: v>;/f`HGz{_%B-]#vT9M}>*;.noJ List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86231 Archived-At: Stefan Monnier wrote: >> 1) Let-bind tty-setup-hook to nil round all calls to >> tty-run-terminal-initialization in term/*.el. > > I don't like let-binding hooks (e.g. it doesn't work right when the hook > has both a global and a buffer-local value). > >> 2) Move running of tty-setup-hook out of tty-run-terminal-initialization, >> into tty-create-frame-with-faces and command-line. > > I haven't looked at it, but it sounds preferable, yes, Or you can have option 3: 3) Add optional DO-NOT-RUN-HOOK (or the inverse) argument to tty-run-terminal-initialization. BTW, I also noticed that the hook runs when emacs --daemon is started, which seems odd?