From: Glenn Morris <rgm@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 16859@debbugs.gnu.org
Subject: bug#16859: tty-setup-hook can run twice
Date: Tue, 25 Feb 2014 17:24:38 -0500 [thread overview]
Message-ID: <yymwhede55.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <slbnxx47cj.fsf@fencepost.gnu.org>
Stefan Monnier wrote:
>> 1) Let-bind tty-setup-hook to nil round all calls to
>> tty-run-terminal-initialization in term/*.el.
>
> I don't like let-binding hooks (e.g. it doesn't work right when the hook
> has both a global and a buffer-local value).
>
>> 2) Move running of tty-setup-hook out of tty-run-terminal-initialization,
>> into tty-create-frame-with-faces and command-line.
>
> I haven't looked at it, but it sounds preferable, yes,
Or you can have option 3:
3) Add optional DO-NOT-RUN-HOOK (or the inverse) argument to
tty-run-terminal-initialization.
BTW, I also noticed that the hook runs when emacs --daemon is started,
which seems odd?
next prev parent reply other threads:[~2014-02-25 22:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 1:39 bug#16859: tty-setup-hook can run twice Glenn Morris
2014-02-25 9:06 ` Glenn Morris
2014-02-25 22:01 ` Stefan Monnier
2014-02-25 22:24 ` Glenn Morris [this message]
2014-02-26 15:55 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yymwhede55.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=16859@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).