From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#8756: 23.3; vc-git.el doesn't use --follow argument in vc-git-print-log Date: Mon, 28 Nov 2011 16:08:32 -0500 Message-ID: References: <87sjrxl0r1.fsf@dod.no> <878vn0yp42.fsf@dod.no> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1322514561 8440 80.91.229.12 (28 Nov 2011 21:09:21 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 28 Nov 2011 21:09:21 +0000 (UTC) Cc: 8756@debbugs.gnu.org To: Steinar Bang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 28 22:09:17 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RV8Rx-0003q5-Is for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Nov 2011 22:09:17 +0100 Original-Received: from localhost ([::1]:45826 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RV8Rw-0001GN-Eo for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Nov 2011 16:09:16 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:49577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RV8Rr-0001FK-LM for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2011 16:09:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RV8Rm-00027C-Ie for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2011 16:09:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41921) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RV8Rm-00026a-6G for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2011 16:09:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RV8Td-0006a0-QD for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2011 16:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Nov 2011 21:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8756 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8756-submit@debbugs.gnu.org id=B8756.132251463325256 (code B ref 8756); Mon, 28 Nov 2011 21:11:01 +0000 Original-Received: (at 8756) by debbugs.gnu.org; 28 Nov 2011 21:10:33 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RV8TA-0006ZJ-KH for submit@debbugs.gnu.org; Mon, 28 Nov 2011 16:10:32 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RV8T8-0006Z9-FJ for 8756@debbugs.gnu.org; Mon, 28 Nov 2011 16:10:31 -0500 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RV8RF-00045O-0V; Mon, 28 Nov 2011 16:08:33 -0500 In-Reply-To: <878vn0yp42.fsf@dod.no> (Steinar Bang's message of "Mon, 28 Nov 2011 21:21:49 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 28 Nov 2011 16:11:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54389 Archived-At: Steinar Bang writes: >>>>>> Dan Nicolaescu : > >> I tried doing that at some point, but the result is not completely >> functional, these commands do not work: >> "d" (log-view-diff) >> "f" (log-view-find-revision) >> "a" (log-view-annotate-revision) > > Yes, I discovered the same thing. > >> which means that the corresponding vc-git.el functions need updating. >> If someone figures out what git commands/sequence of commands are >> needed to implement these, then it should not be too hard to implement >> the needed changes. > > I decided to take a look at it again today. The first problem I ran > into, was that the emacs 23.1 version of `vc-git-print-log' used > "git rev-list" instead of "git log". And only "git log" supports > "--follow" to track renames (at least that's what I concluded after > googling for this today. *Please* correct me, if I'm wrong!). vc-git-print-log currently uses "git log", so your changes should not be needed. > This had slightly more success than the first attempt: > - `C-x v l' reports the full history (as in the previous attempt) > - Now `d', `f', and `a' works for commits newer than the rename > - After the rename > - `d' no longer fails with "No next version", but reports no diff, > where there should have been a diff > #begin_example > No changes between a92a3d062dac1b0ec5eece4ed6f9570e59f1a69b and 8d304db76993a0da0894b3d30794a2c5ec4927fe > #end_example To solve this problem please figure out the git command (or set of commands) that produces the expected diff. Anything displayed in the log buffer can be considered as available. After that we need to figure out how to make VC use that/those command(s). > - `f' and `a' fails because the file doesn't exist > #begin_example > fatal: no such path apps/share/emacs23/site-lisp/vc-git.el in 8d304db76993a0da0894b3d30794a2c5ec4927fe > #end_example Same as above.