From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#9990: valgrind warning in add_row_entry Date: Fri, 18 Nov 2011 14:40:34 -0500 Message-ID: References: <83k47ailf0.fsf@gnu.org> <83zkg2fzgt.fsf@gnu.org> <83vcqqfy5h.fsf@gnu.org> <83k475fsxp.fsf@gnu.org> <83zkftbnwx.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1321645276 1071 80.91.229.12 (18 Nov 2011 19:41:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 18 Nov 2011 19:41:16 +0000 (UTC) Cc: 9990@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 18 20:41:12 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RRUJB-0007bL-8B for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Nov 2011 20:41:09 +0100 Original-Received: from localhost ([::1]:42123 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRUJA-0007BF-SI for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Nov 2011 14:41:08 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:35177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRUJ7-0007Am-U9 for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2011 14:41:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RRUJ6-0004iK-Mp for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2011 14:41:05 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55538) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRUJ6-0004iC-LN for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2011 14:41:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RRUK2-0003s9-B5 for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2011 14:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Nov 2011 19:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9990 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9990-submit@debbugs.gnu.org id=B9990.132164529814856 (code B ref 9990); Fri, 18 Nov 2011 19:42:02 +0000 Original-Received: (at 9990) by debbugs.gnu.org; 18 Nov 2011 19:41:38 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RRUJe-0003rY-84 for submit@debbugs.gnu.org; Fri, 18 Nov 2011 14:41:38 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RRUJY-0003rO-TL for 9990@debbugs.gnu.org; Fri, 18 Nov 2011 14:41:35 -0500 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RRUIc-0003sh-A3; Fri, 18 Nov 2011 14:40:34 -0500 In-Reply-To: <83zkftbnwx.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 18 Nov 2011 14:44:30 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 18 Nov 2011 14:42:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54049 Archived-At: Eli Zaretskii writes: >> From: Dan Nicolaescu >> Cc: 9990@debbugs.gnu.org >> Date: Tue, 15 Nov 2011 11:58:50 -0500 >> >> > If the hash values are always correct where they are used, I guess >> > that excludes the possibility that we use an uninitialized value, >> > right? >> >> I even added an xassert (verify_row_hash (row)) in add_row_entry, and >> it does not trigger. Strange... > > I added such an assert to the trunk. I also fixed a couple of > functions that were destroying the validity of hash codes while > manipulating glyph rows. > > Could you please see if valgrind still complains about add_row_entry > with the current trunk? Unfortunately it still complains in: ==11270== at 0x41314F: adjust_glyph_matrix (dispnew.c:612) ==11270== by 0x4135FC: allocate_matrices_for_window_redisplay (dispnew.c:1869) ==11270== by 0x413B8A: adjust_frame_glyphs (dispnew.c:2199) ==11270== by 0x417137: adjust_glyphs (dispnew.c:1897) ==11270== by 0x44243E: redisplay_internal (xdisp.c:12715) ==11270== by 0x4F6CE2: command_loop_1 (keyboard.c:1589) ==11270== by 0x55BB45: internal_condition_case (eval.c:1499) ==11270== by 0x4E9EAD: command_loop_2 (keyboard.c:1158) ==11270== by 0x55BA27: internal_catch (eval.c:1256) ==11270== by 0x4EB436: recursive_edit_1 (keyboard.c:1137) ==11270== by 0x4EB76B: Frecursive_edit (keyboard.c:821) ==11270== by 0x40E62C: main (emacs.c:1707) ==11270== by 0x415762: update_window (dispnew.c:4244) ==11270== by 0x4166C2: update_window_tree (dispnew.c:3360) ==11270== by 0x418617: update_frame (dispnew.c:3287) ==11270== by 0x44207B: redisplay_internal (xdisp.c:13175) ==11270== by 0x4F6CE2: command_loop_1 (keyboard.c:1589) ==11270== by 0x55BB45: internal_condition_case (eval.c:1499) ==11270== by 0x4E9EAD: command_loop_2 (keyboard.c:1158) ==11270== by 0x55BA27: internal_catch (eval.c:1256) ==11270== by 0x4EB436: recursive_edit_1 (keyboard.c:1137) [line numbers in dispnew.c might be off by a few lines, I have some debugging printfs inserted there]