From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#6709: 24.0.50; With semantic-mode enabled mo-git-blame-current gives a post-command-hook error Date: Mon, 26 Jul 2010 17:41:26 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1280182113 18786 80.91.229.12 (26 Jul 2010 22:08:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 26 Jul 2010 22:08:33 +0000 (UTC) Cc: 6709@debbugs.gnu.org To: "Aneesh Kumar K. V" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 27 00:08:31 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OdVqY-0008Tc-Fq for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Jul 2010 00:08:30 +0200 Original-Received: from localhost ([127.0.0.1]:50389 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OdVqX-0002gP-Ve for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Jul 2010 18:08:29 -0400 Original-Received: from [140.186.70.92] (port=59125 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OdVpj-000276-1I for bug-gnu-emacs@gnu.org; Mon, 26 Jul 2010 18:07:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OdVph-0007Ia-4Q for bug-gnu-emacs@gnu.org; Mon, 26 Jul 2010 18:07:38 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46511) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdVph-0007IV-2M for bug-gnu-emacs@gnu.org; Mon, 26 Jul 2010 18:07:37 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OdVQw-0006wk-JC; Mon, 26 Jul 2010 17:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Jul 2010 21:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6709 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6709-submit@debbugs.gnu.org id=B6709.128018048426696 (code B ref 6709); Mon, 26 Jul 2010 21:42:02 +0000 Original-Received: (at 6709) by debbugs.gnu.org; 26 Jul 2010 21:41:24 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdVQK-0006wX-Cx for submit@debbugs.gnu.org; Mon, 26 Jul 2010 17:41:24 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdVQH-0006wR-Rp for 6709@debbugs.gnu.org; Mon, 26 Jul 2010 17:41:22 -0400 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OdVQM-0005Yr-Ex; Mon, 26 Jul 2010 17:41:26 -0400 In-Reply-To: (Aneesh Kumar K. V.'s message of "Mon\, 26 Jul 2010 19\:37\:32 +0530") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 26 Jul 2010 17:42:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38961 Archived-At: "Aneesh Kumar K. V" writes: > On Sat, 24 Jul 2010 01:23:15 -0400, Dan Nicolaescu wrote: >> aneesh.kumar@linux.vnet.ibm.com writes: >> >> > Here is how to reproduce >> > >> > mo-git-blame can be downloaded from >> > >> > git://git.bunkus.org/mo-git-blame.git >> > >> > emacs -Q >> > M-x load-file mo-git-blame-el >> > open a file in git repository >> > M-x mo-git-blame-current >> > >> > We will see the error >> > >> > Running 'git cat-file'... done >> > Running 'git blame'... >> > Error in post-command-hook: (wrong-type-argument arrayp nil) >> > Git finished. >> > Running 'git blame'... done >> > >> > The error actually disable scroll-all-mode. So further scrolling doesn't >> > cause both windows to scroll >> >> Not really related to your bug report, but from the name it looks like mo-git-blame is a package for >> using "git blame". Can you please tell us what it has that we are >> missing in C-x v g ? > > I quickly tried C-x v g. This is what i found Thanks for doing this! > 1) No incremental blame support. That is we have to wait for the entire > history to be available. Does this make a difference in real life? You might want to file a bug report for this, maybe it will get implemented. > 2) ability to blame previous version/next version in the blame window Isn't that functionality available using the p n a j w keys? Please see the VC-annotate menu for the command names. These commands should work even in the presence of renamed and moved files. > 3) Ability to show the commit information on selecting the commit. You can get the diff (using D) and the log (using L). This might need another bug report, if git users think it's important it can be implemented in about 3-4 lines of code... > 4) No scroll-all-window support so that boththe annotation information > and source code will scroll together The two-column.el package should help doing that... Maybe we need to ask the author of mo-git-blame-el if he wants to implement these features in vc-annotate.el...