From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#6715: 24.0.50; [PATCH] Cygwin build should use pre-crt0.c Date: Sat, 24 Jul 2010 17:34:21 -0400 Message-ID: References: <4C4A1B69.2050100@cornell.edu> <4C4ADB10.4030204@cornell.edu> <4C4B358A.6070009@cornell.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1280007460 26358 80.91.229.12 (24 Jul 2010 21:37:40 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 24 Jul 2010 21:37:40 +0000 (UTC) Cc: "6715@debbugs.gnu.org" <6715@debbugs.gnu.org> To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 24 23:37:38 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OcmPZ-0007ZX-OF for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Jul 2010 23:37:38 +0200 Original-Received: from localhost ([127.0.0.1]:41086 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OcmPZ-0001EV-5o for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Jul 2010 17:37:37 -0400 Original-Received: from [140.186.70.92] (port=32904 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OcmPS-0001Db-De for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2010 17:37:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OcmPR-0001ss-9J for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2010 17:37:30 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60936) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OcmPR-0001so-5f for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2010 17:37:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OcmN3-0001Q9-J6; Sat, 24 Jul 2010 17:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Jul 2010 21:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6715 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 6715-submit@debbugs.gnu.org id=B6715.12800072645454 (code B ref 6715); Sat, 24 Jul 2010 21:35:01 +0000 Original-Received: (at 6715) by debbugs.gnu.org; 24 Jul 2010 21:34:24 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OcmMR-0001Pv-50 for submit@debbugs.gnu.org; Sat, 24 Jul 2010 17:34:23 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OcmMO-0001Pq-Tg for 6715@debbugs.gnu.org; Sat, 24 Jul 2010 17:34:21 -0400 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OcmMP-0005MO-TJ; Sat, 24 Jul 2010 17:34:21 -0400 In-Reply-To: <4C4B358A.6070009@cornell.edu> (Ken Brown's message of "Sat\, 24 Jul 2010 14\:48\:42 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 24 Jul 2010 17:35:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38879 Archived-At: Ken Brown writes: > On 7/24/2010 8:22 AM, Ken Brown wrote: >> On 7/24/2010 1:13 AM, Dan Nicolaescu wrote: >>> BTW, it would be good if you could look at configure.in and see if the >>> line: >>> >>> cygwin) LINKER="\$(CC)" ;; >>> >>> [Just trying to remove special cases from the build system to simplify it...] >> >> There's no need for cygwin to be a special case here. Fixing this also >> makes the cygwin case irrelevant in the code that sets LIB_GCC a little >> further down in configure.in. Please apply the attached patch. > > Never mind. I was just given access to the repository, and I applied > the patch myself. I didn't regenerate configure. I wasn't sure if I > should do that or not. Please do, use autoconf-2.65 and look at the diff for configure, only the few lines that you touched should change. There's no need for a ChangeLog entry for regenerating configure, > Since this is my first commit, I would appreciate it if one of the > experienced people would check that I did it right. The patch looks fine. Thanks! Here's some other cygwin related cleanups: - remove this: #ifdef CYGWIN #define BSD4_2 #endif and instead add defined(CYGWIN) in the right place in the only user: vm-limit.c - in configure.in the setting for lastfile.o cygwin is the only platform that uses different linking order. If the "normal" linking order works on cygwin too, it would simplify the build a bit.