From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#9990: valgrind warning in add_row_entry Date: Fri, 18 Nov 2011 16:43:11 -0500 Message-ID: References: <83k47ailf0.fsf@gnu.org> <83zkg2fzgt.fsf@gnu.org> <83vcqqfy5h.fsf@gnu.org> <83k475fsxp.fsf@gnu.org> <83zkftbnwx.fsf@gnu.org> <83wraxb0ko.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1321652654 21541 80.91.229.12 (18 Nov 2011 21:44:14 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 18 Nov 2011 21:44:14 +0000 (UTC) Cc: 9990@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 18 22:44:09 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RRWED-0005kw-4v for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Nov 2011 22:44:09 +0100 Original-Received: from localhost ([::1]:37568 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRWEB-0007Ie-Tg for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Nov 2011 16:44:07 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:47739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRWE9-0007IS-8n for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2011 16:44:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RRWE8-0004i3-CM for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2011 16:44:05 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55604) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRWE8-0004hz-Am for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2011 16:44:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RRWF4-0007hX-Ix for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2011 16:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Nov 2011 21:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9990 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9990-submit@debbugs.gnu.org id=B9990.132165265529530 (code B ref 9990); Fri, 18 Nov 2011 21:45:02 +0000 Original-Received: (at 9990) by debbugs.gnu.org; 18 Nov 2011 21:44:15 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RRWEI-0007gF-UY for submit@debbugs.gnu.org; Fri, 18 Nov 2011 16:44:15 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RRWEE-0007g5-1y for 9990@debbugs.gnu.org; Fri, 18 Nov 2011 16:44:11 -0500 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RRWDH-00048c-3K; Fri, 18 Nov 2011 16:43:11 -0500 In-Reply-To: <83wraxb0ko.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 18 Nov 2011 23:08:39 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 18 Nov 2011 16:45:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54052 Archived-At: Eli Zaretskii writes: >> From: Dan Nicolaescu >> Cc: 9990@debbugs.gnu.org >> Date: Fri, 18 Nov 2011 14:40:34 -0500 >> >> > I added such an assert to the trunk. I also fixed a couple of >> > functions that were destroying the validity of hash codes while >> > manipulating glyph rows. >> > >> > Could you please see if valgrind still complains about add_row_entry >> > with the current trunk? >> >> Unfortunately it still complains in: >> >> ==11270== at 0x41314F: adjust_glyph_matrix (dispnew.c:612) > > What does this line say in your sources? > xassert (!row->enabled_p || verify_row_hash (row)); > Anyway, seems like a different thing, as there's no add_row_entry near > line 612. And for the other complaint: ==11270== by 0x415762: update_window (dispnew.c:4244) is: ptrdiff_t i = row->hash % row_table_size;