unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Handa Kenichi <handa@gnu.org>
To: Ari Roponen <ari.roponen@gmail.com>
Cc: 14755@debbugs.gnu.org, angelo.graziosi@alice.it
Subject: bug#14755: Trunk bootstrap failure
Date: Wed, 03 Jul 2013 09:39:01 -0400	[thread overview]
Message-ID: <yw7zju3epai.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <8761wvvk6e.fsf@arirop.lan> (message from Ari Roponen on Sun, 30 Jun 2013 15:48:25 +0300)

In article <8761wvvk6e.fsf@arirop.lan>, Ari Roponen <ari.roponen@gmail.com> writes:

> I got the same failure, too. This commit seems to cause it:

>   revno: 113220 [merge]
>   committer: K. Handa <handa@gnu.org>
>   branch nick: trunk
>   timestamp: Sat 2013-06-29 12:46:39 +0900
>   message:
>     Add the coding system prefer-utf-8.
  
> The above commit added this to `select-safe-coding-system':
[...]

> This code fails when the "Kludgy feature" mentioned in the docstring
> is
> used: if FROM is a string, the string is the target text, and TO is
> ignored.

Oops, my fault.

> The following patch seems to fix the problem. Remember to delete
> src/bootstrap-emacs, so that the patched version is used.

Yes, your patch is correct.  Thank you.

---
Kenichi Handa
handa@gnu.org

> === modified file 'lisp/international/mule-cmds.el'
> --- lisp/international/mule-cmds.el   2013-06-28 14:42:55 +0000
> +++ lisp/international/mule-cmds.el   2013-06-30 06:07:06 +0000
> @@ -1031,7 +1031,9 @@
>    (error "Canceled because the buffer was modified"))
>        (if (and (eq (coding-system-type coding-system) 'undecided)
>               (coding-system-get coding-system :prefer-utf-8)
> -                    (< (- to from) (- (position-bytes to)
> (position-bytes from))))
> +                      (if (stringp from)
> +                             (multibyte-string-p from)
> +                                                  (< (- to from) (-
> (position-bytes to) (position-bytes from)))))
>                   (setq coding-system
>                         (coding-system-change-text-conversion
> coding-system 'utf-8)))
>        coding-system)))

> -- 
> Ari Roponen





      parent reply	other threads:[~2013-07-03 13:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-30 11:49 bug#14755: Trunk bootstrap failure Angelo Graziosi
2013-06-30 12:48 ` Ari Roponen
2013-06-30 14:03   ` Angelo Graziosi
2013-06-30 14:29     ` Eli Zaretskii
2013-07-03 13:39   ` Handa Kenichi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yw7zju3epai.fsf@fencepost.gnu.org \
    --to=handa@gnu.org \
    --cc=14755@debbugs.gnu.org \
    --cc=angelo.graziosi@alice.it \
    --cc=ari.roponen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).