From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Handa Kenichi Newsgroups: gmane.emacs.bugs Subject: bug#14781: coding system changes cause make check to hang in icalendar tests Date: Tue, 09 Jul 2013 09:47:51 -0400 Message-ID: References: <6zju35ux8.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1373377690 971 80.91.229.3 (9 Jul 2013 13:48:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 9 Jul 2013 13:48:10 +0000 (UTC) Cc: 14781@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 09 15:48:11 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UwYH3-0001mE-PM for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Jul 2013 15:48:09 +0200 Original-Received: from localhost ([::1]:45789 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwYH3-0002h1-Bz for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Jul 2013 09:48:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwYGy-0002bb-9X for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2013 09:48:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwYGw-0007LQ-W0 for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2013 09:48:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwYGw-0007LK-SU for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2013 09:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1UwYGw-0007NS-4W for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2013 09:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Handa Kenichi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2013 13:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14781-submit@debbugs.gnu.org id=B14781.137337767628342 (code B ref 14781); Tue, 09 Jul 2013 13:48:02 +0000 Original-Received: (at 14781) by debbugs.gnu.org; 9 Jul 2013 13:47:56 +0000 Original-Received: from localhost ([127.0.0.1]:41935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwYGp-0007N1-5H for submit@debbugs.gnu.org; Tue, 09 Jul 2013 09:47:55 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:53003 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwYGn-0007Mn-3g for 14781@debbugs.gnu.org; Tue, 09 Jul 2013 09:47:53 -0400 Original-Received: from handa by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UwYGm-00053G-17; Tue, 09 Jul 2013 09:47:52 -0400 In-Reply-To: (message from Glenn Morris on Mon, 08 Jul 2013 12:52:29 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:76130 Archived-At: In article , Glenn Morris writes: > > Actually, the culprit was test/automated/decoder-tests.el which > > changes priorities of coding systems. I didn't know that all tests > > under test/automated are executed in a single Emacs session, and > > thus > > they must be side-effect free. > I think they should all be side-effect free (as much as possible) > anyway. Someone might well want to run an individual test in an > existing > Emacs session, without that session getting messed up. I generally agree that keeping a test code site-effect free is a good thing, and it makes testing a test code easier. But, sometimes achieving side-effect free is difficult, and in such a case, I think we don't have to spend much effort on it. The main purpose of test is to find bugs. > > Isn't it better to execute each test file in its own Emacs session? > I don't know. Running them all in one is the only way to get the final > number of tests run / passed / failed to be accurate. Here's a rough idea to do that in test/automated/Makefile.in. TEST_RESULTS = $(patsubst %.el, %.dat, $(wildcard *.el)) .SUFFIXES: .dat .el .el.dat: @$(emacs) -f ert-run-tests-batch-and-exit-with-report $< $@ check: $(TEST_RESULTS) @$(emacs) -f ert-summarize-test-report $(TEST_RESULTS) Note that ert-run-tests-batch-and-exit-with-report and ert-report-test-results are not yet implemented. > Running them in > separate Emacs's would allow them to run in parallel, which would be > faster, but might be confusing? The faster the better, but I think the speed is not that important here. The merit of the above method is that we can run a single test file just by "make XXXX.dat". --- Kenichi Handa handa@gnu.org