From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#13622: 24.3.50; doc-view: Use (and prefer) soffice as default ODF->PDF converter Date: Tue, 05 Feb 2013 03:04:13 -0500 Message-ID: References: <87ip69b4ro.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1360051504 967 80.91.229.3 (5 Feb 2013 08:05:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Feb 2013 08:05:04 +0000 (UTC) Cc: 13622@debbugs.gnu.org To: Jambunathan K Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 05 09:05:25 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U2dWu-0008Ty-OV for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Feb 2013 09:05:24 +0100 Original-Received: from localhost ([::1]:33213 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2dWY-0005PU-PA for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Feb 2013 03:05:02 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2dWV-0005HW-8H for bug-gnu-emacs@gnu.org; Tue, 05 Feb 2013 03:05:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U2dWQ-0006Ui-96 for bug-gnu-emacs@gnu.org; Tue, 05 Feb 2013 03:04:59 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2dWQ-0006UQ-6b for bug-gnu-emacs@gnu.org; Tue, 05 Feb 2013 03:04:54 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U2dXV-0008Fp-LS for bug-gnu-emacs@gnu.org; Tue, 05 Feb 2013 03:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Feb 2013 08:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13622 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13622-submit@debbugs.gnu.org id=B13622.136005152531680 (code B ref 13622); Tue, 05 Feb 2013 08:06:01 +0000 Original-Received: (at 13622) by debbugs.gnu.org; 5 Feb 2013 08:05:25 +0000 Original-Received: from localhost ([127.0.0.1]:36958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2dWu-0008Eu-Di for submit@debbugs.gnu.org; Tue, 05 Feb 2013 03:05:24 -0500 Original-Received: from fencepost.gnu.org ([208.118.235.10]:50396) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2dWs-0008Eo-R7 for 13622@debbugs.gnu.org; Tue, 05 Feb 2013 03:05:23 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U2dVl-0003Nu-4Z; Tue, 05 Feb 2013 03:04:13 -0500 X-Spook: Delta Force S Key UOP Hamas Croatian AUTODIN Kh-11 freedom X-Ran: UHraP$1^"PA@d]m$V/7?~?o9R!-$Ge2Y54X5ufQXivyh]W9Xxy?)a{p8.R+JjX3Q|]YQVP X-Hue: cyan X-Attribution: GM In-Reply-To: <87ip69b4ro.fsf@gmail.com> (Jambunathan K.'s message of "Mon, 04 Feb 2013 00:31:47 +0530") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70710 Archived-At: Jambunathan K wrote: > I am attaching a patch. Please apply to trunk. Some explanation as to why would be nice. > +(defcustom doc-view-odf->pdf-converter-program > + (cond > + ((executable-find "soffice") "soffice") > + ((executable-find "unoconv") "unoconv")) This could end up being nil, which would give a type mismatch with 'file. > :type 'file > > +(defcustom doc-view-odf->pdf-converter-function > + (cond > + ((string-match "unoconv\\'" doc-view-odf->pdf-converter-program) > + #'doc-view-odf->pdf-converter-unoconv) > + ((string-match "soffice\\'" doc-view-odf->pdf-converter-program) > + #'doc-view-odf->pdf-converter-soffice)) > + "Function to call to convert a ODF file into a PDF file." > + :type '(radio > + (function-item doc-view-odf->pdf-converter-unoconv > + :doc "Use unoconv") > + (function-item doc-view-odf->pdf-converter-soffice > + :doc "Use LibreOffice") > + function) > + :version "24.4") Why do you need this, as opposed to a single function which calls -program with a customizable -program-options argument?