From: Glenn Morris <rgm@gnu.org>
To: Jambunathan K <kjambunathan@gmail.com>
Cc: 13622@debbugs.gnu.org
Subject: bug#13622: 24.3.50; doc-view: Use (and prefer) soffice as default ODF->PDF converter
Date: Tue, 05 Feb 2013 03:04:13 -0500 [thread overview]
Message-ID: <yswqunjif6.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87ip69b4ro.fsf@gmail.com> (Jambunathan K.'s message of "Mon, 04 Feb 2013 00:31:47 +0530")
Jambunathan K wrote:
> I am attaching a patch. Please apply to trunk.
Some explanation as to why would be nice.
> +(defcustom doc-view-odf->pdf-converter-program
> + (cond
> + ((executable-find "soffice") "soffice")
> + ((executable-find "unoconv") "unoconv"))
This could end up being nil, which would give a type mismatch with 'file.
> :type 'file
>
> +(defcustom doc-view-odf->pdf-converter-function
> + (cond
> + ((string-match "unoconv\\'" doc-view-odf->pdf-converter-program)
> + #'doc-view-odf->pdf-converter-unoconv)
> + ((string-match "soffice\\'" doc-view-odf->pdf-converter-program)
> + #'doc-view-odf->pdf-converter-soffice))
> + "Function to call to convert a ODF file into a PDF file."
> + :type '(radio
> + (function-item doc-view-odf->pdf-converter-unoconv
> + :doc "Use unoconv")
> + (function-item doc-view-odf->pdf-converter-soffice
> + :doc "Use LibreOffice")
> + function)
> + :version "24.4")
Why do you need this, as opposed to a single function which calls
-program with a customizable -program-options argument?
next prev parent reply other threads:[~2013-02-05 8:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-03 19:01 bug#13622: 24.3.50; doc-view: Use (and prefer) soffice as default ODF->PDF converter Jambunathan K
2013-02-05 8:04 ` Glenn Morris [this message]
2013-02-05 10:53 ` Jambunathan K
2013-02-05 11:50 ` Jambunathan K
2013-02-09 5:29 ` Chong Yidong
2013-02-09 10:03 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yswqunjif6.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=13622@debbugs.gnu.org \
--cc=kjambunathan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).