From: Raffael Stocker <r.stocker@mnet-mail.de>
To: 72091@debbugs.gnu.org
Subject: bug#72091: 30.0.60; [PATCH] Emacs won't close notifications on Windows
Date: Sat, 13 Jul 2024 13:37:22 +0200 [thread overview]
Message-ID: <yplmo771r099.fsf@mnet-mail.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 236 bytes --]
Hi,
the current Windows build of Emacs won't close notifications. This is
due to a typo recently introduced in ‘w32-notification-close’ that
inverts a function pointer check. See the attached patch.
Regards,
Raffael
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fixes typo in w32-notification-close --]
[-- Type: text/x-patch, Size: 689 bytes --]
From c9996e0427762c264b6678269e83964e96ffd3ec Mon Sep 17 00:00:00 2001
From: Raffael Stocker <r.stocker@mnet-mail.de>
Date: Sat, 13 Jul 2024 13:26:23 +0200
Subject: [PATCH] ; * src/w32fns.c (Fw32_notification_close): fix typo
---
src/w32fns.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/w32fns.c b/src/w32fns.c
index 7fc2f598b3e..e5798fdd84f 100644
--- a/src/w32fns.c
+++ b/src/w32fns.c
@@ -10472,7 +10472,7 @@ DEFUN ("w32-notification-close",
{
struct frame *f = SELECTED_FRAME ();
- if (FIXNUMP (id) && !pfnShell_NotifyIconW)
+ if (FIXNUMP (id) && pfnShell_NotifyIconW)
delete_tray_notification (f, XFIXNUM (id));
return Qnil;
--
2.45.2
next reply other threads:[~2024-07-13 11:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-13 11:37 Raffael Stocker [this message]
2024-07-13 12:20 ` bug#72091: 30.0.60; [PATCH] Emacs won't close notifications on Windows Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yplmo771r099.fsf@mnet-mail.de \
--to=r.stocker@mnet-mail.de \
--cc=72091@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).