From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Chinmay Dalal Newsgroups: gmane.emacs.bugs Subject: bug#61412: Inlay activation Date: Wed, 15 Feb 2023 21:54:57 +0530 Message-ID: References: <20230211081335.312224-1-dalal.chinmay.0101@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8353"; mail-complaints-to="usenet@ciao.gmane.io" Cc: joaotavora@gmail.com To: 61412@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 15 18:52:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSLx6-00021x-Sg for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Feb 2023 18:52:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSLwp-00038t-QO; Wed, 15 Feb 2023 12:52:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSLwo-00038l-TY for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 12:52:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSLwo-00060R-Ar for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 12:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSLwn-0003Nr-OK for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 12:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Chinmay Dalal Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Feb 2023 17:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61412 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61412-submit@debbugs.gnu.org id=B61412.167648346812943 (code B ref 61412); Wed, 15 Feb 2023 17:52:01 +0000 Original-Received: (at 61412) by debbugs.gnu.org; 15 Feb 2023 17:51:08 +0000 Original-Received: from localhost ([127.0.0.1]:33872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSLvr-0003Ma-19 for submit@debbugs.gnu.org; Wed, 15 Feb 2023 12:51:07 -0500 Original-Received: from mail-pl1-f178.google.com ([209.85.214.178]:37702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSKjd-0001D3-2v for 61412@debbugs.gnu.org; Wed, 15 Feb 2023 11:34:21 -0500 Original-Received: by mail-pl1-f178.google.com with SMTP id m2so20763455plg.4 for <61412@debbugs.gnu.org>; Wed, 15 Feb 2023 08:34:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:subject:cc:to:from:in-reply-to:message-id:from:to:cc:subject :date:message-id:reply-to; bh=5D7zCOb+Nu0nMUQfRJxabpEc67BPdJ9c+/Hrs3293vQ=; b=CkAmYVS5ZRd5D9w/pov6cvPZc3ooWzgn2n1dELA53HYsqFmLc+p6uQO/7TduyLuEf/ /NOpWBWdKkA+AR+NKnOV5sV9Sks6ZVaelQ456ArieBaa6IVv0CZtjjckDK1nEP/ByHOs J/ny60iCEymArj7Ho3B1RfR3FurkbMMcw1VD8KMIfEkRrVCDajI3/NJ/4cWVVedNSMmY phRgsL1gIXRNSEpUPrcBeJEAe8EtDKyVJ4VLJygcMPMXbsSowdRzXBDiK0K1YcIxnocV dNEFJPsE2Cg4xwwi5Xi0GmwhoyVO48TmoDEYoqAVno15J4a1qqN5c6dJamkC8VxwPVOA aaOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=date:subject:cc:to:from:in-reply-to:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5D7zCOb+Nu0nMUQfRJxabpEc67BPdJ9c+/Hrs3293vQ=; b=n1WtAj32CnMJtz2Tdm9+oqthxfFpOf04iz6+rjuLzoxo3qQL4No6KnOHfTaOr7HfHt ds0+2EikyONf6auUrKfIqubvaunl6c16rbqGv5cXaTA9u/mya6sW8HLxUHxQeXf/W3j9 or99iDJ40n2KnJgeVHZDrmmKuFKQBHS0U5QChi28ok0Pc++XMBVoAq+HtHF7jlxFmtfx 7t1aBSAI5uCvG63m5bst8zcWn/9XI3joqPh69HWLqhJkqRlCyoRqX+pXHtHJrWcjgrrp B8fIgYO1dp95nUMyMfCIiJataDsHhUgwB+Z5HmUTnz9M4NPShBE4Meosvza3PU6gCAyW 3JJg== X-Gm-Message-State: AO0yUKWKYtCr1ruqiXO10gTs9HKbFis5AhZXykYR0zBVlY6G8YVVv/Wd gY5fmXAOXUAKw5oY5i5NUWM= X-Google-Smtp-Source: AK7set+kqSdH7pgvOxKgNPvjdIQqsrAFWydajv3GBhPZIbFXAb8+PQ6rmjrCWc7bfwBpX18+DMwDww== X-Received: by 2002:a17:90b:1b11:b0:233:e0d8:9b81 with SMTP id nu17-20020a17090b1b1100b00233e0d89b81mr3503914pjb.20.1676478855157; Wed, 15 Feb 2023 08:34:15 -0800 (PST) Original-Received: from ganymede ([115.244.45.193]) by smtp.gmail.com with ESMTPSA id gx11-20020a17090b124b00b002309279baf8sm1660042pjb.43.2023.02.15.08.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 08:34:14 -0800 (PST) In-Reply-To: CALDnm50kZFT_rRUss9ZR4vU6P_xTm7hAfKQJw8PSQi8SOdkGDw@mail.gmail.com X-Mailman-Approved-At: Wed, 15 Feb 2023 12:51:02 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255750 Archived-At: > Yes. I haven't looked at your code, but my expectation is for inlay hints to > activate either on a timer after each change, or by the explicit request of > the user via a keybinding. My code updates inlay hints on every save (`after-save-hook`). Regarding keybinding, on the github discussion someone suggested that vscode shows them while a key combination is held and hides them when they are released, but I was told emacs can't do this. Regarding timer, personally I find it annoying when lsp-mode starts showing overlays when I'm not done typing a line, which is why I chose after-save-hook. For me it would be best if they were updated every time I pressed enter, but I don't know how to implement that.