From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#67005: 30.0.50; improve nadivce/comp/trampoline handling Date: Thu, 16 Nov 2023 03:46:12 -0500 Message-ID: References: <874jhv9921.fsf@sappc2.fritz.box> <875y24zrt1.fsf@sappc2.fritz.box> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28282"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jens Schmidt , 67005@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 16 09:47:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r3Y1x-00075j-Jk for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Nov 2023 09:47:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3Y1i-0002du-8y; Thu, 16 Nov 2023 03:47:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3Y1f-0002bV-G5 for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2023 03:47:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3Y1f-0001JB-8E for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2023 03:47:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3Y1e-0004oH-HJ for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2023 03:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Nov 2023 08:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67005 X-GNU-PR-Package: emacs Original-Received: via spool by 67005-submit@debbugs.gnu.org id=B67005.170012438317616 (code B ref 67005); Thu, 16 Nov 2023 08:47:02 +0000 Original-Received: (at 67005) by debbugs.gnu.org; 16 Nov 2023 08:46:23 +0000 Original-Received: from localhost ([127.0.0.1]:54441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3Y11-0004Zt-Gf for submit@debbugs.gnu.org; Thu, 16 Nov 2023 03:46:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3Y0x-0004WN-He for 67005@debbugs.gnu.org; Thu, 16 Nov 2023 03:46:22 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3Y0s-0001Fk-1g; Thu, 16 Nov 2023 03:46:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=IKvbqd0OUjmKA6yJhPwL8dNEi07jo1EDvlTnnxCQmMI=; b=eycCkBnrcrmfRvEKak3c E0K28qEXm9zccornvgTP4bpVk5JVu5r3VEFH7SJhUCkr392KMk6nkL9fURWz0CtsGrgWiMqHpyKGf QBgpzkfqq17rEe275colzwhPo5Z+2/NbN0le78hMiEnt/qaTN2SntzOZXWLLVKiklTf+Sbr8fnVnZ YBoddo1lthQxdaQMtebLd3kPUCVpbcWVmTUqCMZf4Wu6JvoshOuSnLvUeeo8UCO6g9J3fm+o1RaX0 VyvI/S/NoqhKEdmGmyfvGY6yT3v7HWRgMtZc8vGfj9ttxZDrs5/+eu+dQaD5YX288qw1jbdk2htpR LoWzQeoQv78TPw==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1r3Y0q-0008IS-Ov; Thu, 16 Nov 2023 03:46:13 -0500 In-Reply-To: (Stefan Monnier's message of "Tue, 14 Nov 2023 19:06:38 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274443 Archived-At: Stefan Monnier writes: [...] >> Another suspectible spot is the following from function `Ffset': >> >> if (!NILP (Vnative_comp_enable_subr_trampolines) >> && SUBRP (function) >> && !SUBR_NATIVE_COMPILEDP (function)) >> CALLN (Ffuncall, Qcomp_subr_trampoline_install, symbol); > > Actually, I don't understand this code now that I re-(re-)*read it. > Why do we negate the SUBR_NATIVE_COMPILEDP (function)? "function" is the function we are redefining and we want to trigger the trampoline thing only when that's a C primitive. Those two conditions are equivalent to 'subr-primitive-p'. Andrea