From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#71654: [PATCH] Fix display-buffer-override-next-command Date: Wed, 19 Jun 2024 17:32:01 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20384"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 71654-done@debbugs.gnu.org To: kassick@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 19 23:33:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sK2vk-00057h-NL for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Jun 2024 23:33:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sK2vQ-0000WP-8p; Wed, 19 Jun 2024 17:33:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sK2vL-0000Vf-M3 for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 17:33:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sK2vK-0006Gt-Ni for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 17:32:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sK2vN-0003LF-TM for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 17:33:01 -0400 Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jun 2024 21:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 71654 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 71654@debbugs.gnu.org, acorallo@gnu.org, kassick@gmail.com Original-Received: via spool by 71654-done@debbugs.gnu.org id=D71654.171883273612755 (code D ref 71654); Wed, 19 Jun 2024 21:33:01 +0000 Original-Received: (at 71654-done) by debbugs.gnu.org; 19 Jun 2024 21:32:16 +0000 Original-Received: from localhost ([127.0.0.1]:60009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK2ud-0003Jb-Fa for submit@debbugs.gnu.org; Wed, 19 Jun 2024 17:32:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK2ub-0003JC-6U for 71654-done@debbugs.gnu.org; Wed, 19 Jun 2024 17:32:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sK2uR-0006Dq-S6; Wed, 19 Jun 2024 17:32:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=kG4jLObIRZtn3VC0ykoCiSR7/Om7G6eVOVc568bYmio=; b=oP7SkM1Kqnn1QDr72jKd co4Acxu+e9FZ8MzzC3scVt9ma7sAtKdI6N+eQHAHliHu5/2LjvW7uSo09VnE8s8kGkEFVQ6zYjAPZ x7uEt14z3no71ZP9uQfhkBwlVpolboYhI4Qx9Mjxe8DBLeOy2FO3gKBEoWcgduk8OwRNrjC84hIFr HdGubqW2Zsh8/il+0b1eluUOK2a8Q/aQVP/anpFoYhKROBlyCuHziFUlN5uWtNZjMmX2tH6/+KWGL dMmBiXooo5sJCWOWcyShLcgMtRJf1fRuij7VvL2SETmzDL5aim4QlCj8ZCVC9XpGeH0vq0rgW4Eyk 6+Z4FcGV6NyHEg==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sK2uP-0005hz-ND; Wed, 19 Jun 2024 17:32:03 -0400 In-Reply-To: (kassick@gmail.com's message of "Wed, 19 Jun 2024 12:20:19 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287514 Archived-At: "kassick@gmail.com" writes: > When display-buffer-overriding-action's car is set to a function instead of a list, display-buffer-override-next-command > must ensure that the car is a list before pushing a new element to it, otherwise the car will become a itself a cons-cell > and the clear-fun will trigger a wrong-type-argumen error when trying to delq the action. > > The error can be triggered by using some minor mode that updates display-buffer-override-next-command (such as > purpose-mode) and then calling other-window-prefix. Hi Rodrigo, the patch LGTM so I applied it after some indentation massage to master. Closing then, happy to reopen if some more work is needed. Thanks Andrea