From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#71934: comp--spill-lap-function and closure (wad: bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects) Date: Mon, 08 Jul 2024 04:47:05 -0400 Message-ID: References: <87bk3b8h2n.fsf@web.de> <871q44br8r.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33521"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Heerdegen , Alan Mackenzie , Eli Zaretskii , 71934@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 08 10:48:40 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQk36-0008TB-7Y for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Jul 2024 10:48:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQk2p-00027E-O6; Mon, 08 Jul 2024 04:48:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQk2R-0001Jq-Fy for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2024 04:48:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sQk2R-0006Vy-7L for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2024 04:47:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sQk2V-0007eP-2u for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2024 04:48:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jul 2024 08:48:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71934 X-GNU-PR-Package: emacs Original-Received: via spool by 71934-submit@debbugs.gnu.org id=B71934.172042844029341 (code B ref 71934); Mon, 08 Jul 2024 08:48:03 +0000 Original-Received: (at 71934) by debbugs.gnu.org; 8 Jul 2024 08:47:20 +0000 Original-Received: from localhost ([127.0.0.1]:49632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQk1n-0007dB-L6 for submit@debbugs.gnu.org; Mon, 08 Jul 2024 04:47:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQk1l-0007cl-MZ for 71934@debbugs.gnu.org; Mon, 08 Jul 2024 04:47:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQk1a-0006K0-E1; Mon, 08 Jul 2024 04:47:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=XSKBfO3cEP0ZM2tFs+HCgpfGzXpiwr2toPzASgLOq+w=; b=AqYtkJBE/l1mi/4D8QaQ hGhdNVIkQWLyXdLwpZUJwWW6I4wpW1audtsRZr9ss3xM8pmNJc1PPAmWeLUJjvSdej3ZEPmOYg2cR 45RqPsCd6xgg2XNWchwcQYSoKqGFhWk7HqzD3iRE9Z5gzzRkMaxQGXg325nP1mrSl3OT9A8khkUeq sPDGaQROQbKcLOO5abhsNCfjhUTXhgxVjcgrmBDyhGuw6bJ157aLFe7mygpVTTyTOe9OnlDUWvXn4 efvwN4fjS6c91qkP/JK8mUIHx1YsU/gJQ92wx86HwV1JpWKZQSKCS7QK2f3mN547EHWQKmEkC13jI TDvJXpcVKS1k1g==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sQk1Z-0005Cw-Ss; Mon, 08 Jul 2024 04:47:05 -0400 In-Reply-To: (Stefan Monnier's message of "Sun, 07 Jul 2024 22:32:43 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288582 Archived-At: Stefan Monnier writes: >>> It's apparent that the one that used to work, >>> >>> (cl-defmethod comp--spill-lap-function ((form list)) >>> >>> , no longer works since function forms were converted to a different >>> format in March. It needs modifying to handle the new format. >> >> That was the question. >> >> So, of what kind can the argument FORM be? Any form (any lisp >> expression - any kind of "code") - lambda lists, function values? >> >> As far as I understand the above method originally supported lambda >> lists and you made it handle function values as well. And because >> function values are now represented differently the above method does >> not handle this case any more. >> >> Is this correct? > > Yeah, I also fail to understand the relationship between > `comp--spill-lap-function` (which sounds internal to the compilation > pipeline and thus might apply to all sorts of subexpressions of the > input code) and `native-compile` (where adding support for function > values affects only the "toplevel" of the input). 'comp--spill-lap-function' serves 'comp--spill-lap' which is the first pass of the native compilation pipeline. So adding a new method there is the usual way to make native-compile support new kind of inputs. Andrea