From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#64646: Master: Native compiler doesn't always compile lambda forms. Date: Thu, 02 Nov 2023 13:32:21 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16138"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 64646@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 02 18:33:49 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qybZl-0003yl-2Z for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Nov 2023 18:33:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qybZR-0001Uu-KQ; Thu, 02 Nov 2023 13:33:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qybZQ-0001Ua-2l for bug-gnu-emacs@gnu.org; Thu, 02 Nov 2023 13:33:28 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qybZP-0000X0-Qi for bug-gnu-emacs@gnu.org; Thu, 02 Nov 2023 13:33:27 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qybZy-0001xA-Jp for bug-gnu-emacs@gnu.org; Thu, 02 Nov 2023 13:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Nov 2023 17:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64646 X-GNU-PR-Package: emacs Original-Received: via spool by 64646-submit@debbugs.gnu.org id=B64646.16989463977449 (code B ref 64646); Thu, 02 Nov 2023 17:34:02 +0000 Original-Received: (at 64646) by debbugs.gnu.org; 2 Nov 2023 17:33:17 +0000 Original-Received: from localhost ([127.0.0.1]:55978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qybZA-0001w1-SD for submit@debbugs.gnu.org; Thu, 02 Nov 2023 13:33:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qybZ5-0001vl-Q8 for 64646@debbugs.gnu.org; Thu, 02 Nov 2023 13:33:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qybYO-0000Jo-C3; Thu, 02 Nov 2023 13:32:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=LlgCdgliwEvz3aSfyAXYEDpUoXmDZJ8TBUsKgMAaawc=; b=jJfjiuMQZX+9i6gojXBS Xg6kChlkuS8Lzb98qiRuI+VEXVgb9lIA3ACbwE6gnHIlRyfvq7kbwTA6otE1OeqkiuLAtyvtPu8SZ RVPCaBFVS0fYUH4MwtZcjqqtNa79YQn6zamPsuqh2W8qvp/ZcvX8mg25bDBUgu8uFpeamFj8LZJHo VOuwKWRFPXX5l2qSO/i5tcyTQ+twbkNlwz1euf2bG4UZKyxH99MBy+zYdcN6OsMUe8yNOCOjG1nmc evSA9CTTXFgMfsoLqMqTYw849aW3rTGgDbz9J6d8/F5iA5RdL0Yy7zTee8PSzXJc8hbGi9Qybi+OK 7D5RilCYno13zQ==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1qybYL-0004Cf-Ob; Thu, 02 Nov 2023 13:32:22 -0400 In-Reply-To: (Alan Mackenzie's message of "Sun, 29 Oct 2023 13:21:02 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273666 Archived-At: Alan Mackenzie writes: > Hello, Andrea. > > This bug doesn't seem to be moving, so .... > > On Wed, Jul 26, 2023 at 10:57:01 -0400, Andrea Corallo wrote: >> Alan Mackenzie writes: > >> > Hello, Andrea. > >> > On Mon, Jul 17, 2023 at 09:17:13 -0400, Andrea Corallo wrote: >> >> Alan Mackenzie writes: > >> >> > In the master branch: > >> >> > (i) emacs -Q >> >> > (ii) C-x b foo.el >> >> > (iii) Insert into foo.el: >> >> > ;; -*- lexical-binding:t -*- >> >> > (iv) M-x emacs-lisp-mode >> >> > (v) Insert into foo.el: >> >> > (defun foo () "foo doc string" >> >> > (lambda (bar) "lambda doc string" (car bar))) >> >> > (vi) With point after the function, C-x C-e to evaluate it. > >> >> > (vii) M-: (native-compile 'foo) >> >> > This returns # >> >> > (viii) M-: (foo) >> >> > This returns the lambda form as a byte-compiled function. This is a bug: >> >> > it should return the lambda form as a native-compiled function. > >> >> > Note: this bug is also in the emacs-29 branch. > >> >> Hi Alan, > >> >> I can reproduce, (native-compile 'foo) compiles only foo, compiling the >> >> whole compilation unit with eg `emacs-lisp-native-compile-and-load' >> >> compiles as expected also the inner lambda. > >> > Why would compiling a .el file compile inner lambda forms, but >> > native-compile doesn't? > >> >> I'm not 100% convinced this behaviour is a bug tho. > >> > I don't understand that. Why might it be incorrect to compile that inner >> > lambda natively? > >> Hi Alan, > >> I'm not saying it would be incorrect. I'm suggesting that if is not >> specified what's the expected behaviour of compiling by name the outer >> lambda it might not be a bug. > >> When we compile a whole compilation unit we indeed have to compile all >> functions, in this case what we promised is I think not defined. > > I still don't understand that. The doc string for native-compile says: > > Compile FUNCTION-OR-FILE into native code. > > .. I can't see any reason not also to compile inner lambda functions > natively. > > Anyhow, to fix this bug (if such it be) is easy: > > diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el > index 181e5ca96a1..2360fbaa494 100644 > --- a/lisp/emacs-lisp/comp.el > +++ b/lisp/emacs-lisp/comp.el > @@ -1359,7 +1359,12 @@ comp-add-func-to-ctxt > (comp-ctxt-top-level-forms comp-ctxt) > (list (make-byte-to-native-func-def :name function-name > :c-name c-name))) > - (comp-add-func-to-ctxt func)))) > + (comp-add-func-to-ctxt func)) > + ;; Handle any lambda functions in BYTE-CODE. > + (maphash (lambda (key val) > + (unless (eq key (aref byte-code 1)) > + (comp-intern-func-in-ctxt key val))) > + byte-to-native-lambdas-h))) > > (cl-defmethod comp-spill-lap-function ((form list)) > "Byte-compile FORM, spilling data from the byte compiler." > > > What do you say? LGTM as long as indeed it does not regress any test. Speaking of which with the patch I guess we want a test to cover this. > Incidentally, the code in the various comp-spill-lap-function methods > together with comp-intern-func-in-ctxt appears to have some code > duplication. Would it be possible to have the symbol and list methods of > comp-spill-lap-function simply call comp-intern-func-in-ctxt the way the > string method does? That would simplify those two methods quite a bit. Mmmh maybe, I think one has to try to see if the result is satisfactory. Thanks Andrea