unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#71338: 30.0.50; [PATCH] Support ada-ts-mode, gpr-mode and gpr-ts-mode in Eglot
@ 2024-06-03 12:20 Troy Brown
  2024-06-03 15:32 ` Andrea Corallo
  0 siblings, 1 reply; 4+ messages in thread
From: Troy Brown @ 2024-06-03 12:20 UTC (permalink / raw)
  To: 71338

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

The following patch adds support within Eglot for ada-ts-mode,
gpr-mode and gpr-ts-mode.  Note that the Ada language server supports
Ada by default but supports GNAT Project if the "--language-gpr"
option is specified.

[-- Attachment #2: 0001-Support-ada-ts-mode-gpr-mode-and-gpr-ts-mode-in-Eglo.patch --]
[-- Type: text/x-patch, Size: 1095 bytes --]

From 2a50358c4fbd87dd1d63a257decc294b61e9379b Mon Sep 17 00:00:00 2001
From: Troy Brown <brownts@troybrown.dev>
Date: Sun, 2 Jun 2024 11:48:54 -0400
Subject: [PATCH] Support ada-ts-mode, gpr-mode and gpr-ts-mode in Eglot

* lisp/progmodes/eglot.el (eglot-server-programs): Add
ada-ts-mode, gpr-mode and gpr-ts-mode.

Copyright-paperwork-exempt: yes
---
 lisp/progmodes/eglot.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index edbe484157b..5ccae5210fe 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -287,7 +287,8 @@ eglot-server-programs
             '("language_server.bat")
           (eglot-alternatives
            '("language_server.sh" "start_lexical.sh"))))
-    (ada-mode . ("ada_language_server"))
+    ((ada-mode ada-ts-mode) . ("ada_language_server"))
+    ((gpr-mode gpr-ts-mode) . ("ada_language_server" "--language-gpr"))
     (scala-mode . ,(eglot-alternatives
                     '("metals" "metals-emacs")))
     (racket-mode . ("racket" "-l" "racket-langserver"))
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#71338: 30.0.50; [PATCH] Support ada-ts-mode, gpr-mode and gpr-ts-mode in Eglot
  2024-06-03 12:20 bug#71338: 30.0.50; [PATCH] Support ada-ts-mode, gpr-mode and gpr-ts-mode in Eglot Troy Brown
@ 2024-06-03 15:32 ` Andrea Corallo
  2024-06-03 15:40   ` João Távora
  0 siblings, 1 reply; 4+ messages in thread
From: Andrea Corallo @ 2024-06-03 15:32 UTC (permalink / raw)
  To: Troy Brown; +Cc: 71338, João Távora

Troy Brown <brownts@troybrown.dev> writes:

> The following patch adds support within Eglot for ada-ts-mode,
> gpr-mode and gpr-ts-mode.  Note that the Ada language server supports
> Ada by default but supports GNAT Project if the "--language-gpr"
> option is specified.

Adding João.

Thanks

  Andrea





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#71338: 30.0.50; [PATCH] Support ada-ts-mode, gpr-mode and gpr-ts-mode in Eglot
  2024-06-03 15:32 ` Andrea Corallo
@ 2024-06-03 15:40   ` João Távora
  2024-06-03 16:00     ` Andrea Corallo
  0 siblings, 1 reply; 4+ messages in thread
From: João Távora @ 2024-06-03 15:40 UTC (permalink / raw)
  To: Andrea Corallo; +Cc: Troy Brown, 71338

Looks fine.  These changes to the DB can go without my
approval.  Ideally it'd be code in the major modes setting
some Eglot specific variable, but I'm not working on it.

João

On Mon, Jun 3, 2024 at 4:32 PM Andrea Corallo <acorallo@gnu.org> wrote:
>
> Troy Brown <brownts@troybrown.dev> writes:
>
> > The following patch adds support within Eglot for ada-ts-mode,
> > gpr-mode and gpr-ts-mode.  Note that the Ada language server supports
> > Ada by default but supports GNAT Project if the "--language-gpr"
> > option is specified.
>
> Adding João.
>
> Thanks
>
>   Andrea



-- 
João Távora





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#71338: 30.0.50; [PATCH] Support ada-ts-mode, gpr-mode and gpr-ts-mode in Eglot
  2024-06-03 15:40   ` João Távora
@ 2024-06-03 16:00     ` Andrea Corallo
  0 siblings, 0 replies; 4+ messages in thread
From: Andrea Corallo @ 2024-06-03 16:00 UTC (permalink / raw)
  To: João Távora; +Cc: Troy Brown, 71338-done

João Távora <joaotavora@gmail.com> writes:

> Looks fine.  These changes to the DB can go without my
> approval.  Ideally it'd be code in the major modes setting
> some Eglot specific variable, but I'm not working on it.

Okay cool, pushed and closing.

Thanks

  Andrea





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-06-03 16:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-03 12:20 bug#71338: 30.0.50; [PATCH] Support ada-ts-mode, gpr-mode and gpr-ts-mode in Eglot Troy Brown
2024-06-03 15:32 ` Andrea Corallo
2024-06-03 15:40   ` João Távora
2024-06-03 16:00     ` Andrea Corallo

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).