From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#57627: 29.0.50; [native-compilation] cl-loaddefs.el recompiled on startup Date: Sun, 13 Oct 2024 18:12:19 -0400 Message-ID: References: <1ec93fc2a0eaa42f9d6464984867031f@webmail.orcon.net.nz> <86tteihdxy.fsf@gnu.org> <26e8c6a5ade1c40d841f27e85270b07c@webmail.orcon.net.nz> <86ikug6twn.fsf@gnu.org> <865xpxy3c2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38362"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: psainty@orcon.net.nz, 57627@debbugs.gnu.org, larsi@gnus.org, arash@gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 14 00:14:35 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t06rC-0009qZ-6T for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Oct 2024 00:14:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t06pU-000793-3J; Sun, 13 Oct 2024 18:12:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t06pS-00078F-FD for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2024 18:12:46 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t06pS-0000uk-6r for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2024 18:12:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=HdftYvKO/eZ7VPzm+dBzKcjaypocPKIvm1pZM2j7N9s=; b=t+D8dmeNHNvYGIDkTJsx/2wPgI3UMg15Pz/cmPgPw5ZHkVW5BN5DQpOPN4d8Y9Vdfvan8BFIXpIXA8ErBe7w6bk24HilqQY+ROLCFeE0Vw7sSNtnlZnNP/xkfnjL60fqfZBiuuKeX2BSIJsd1khdCupLEvjMGMPUxrrAEezZDQ8T+BYg53hzAzIe6iRJZ814jz/s30B1C5J3EQ1rmqgRCnUYeR9xfSQUKd6xv8do2dydQ0G6hrcSIzqZOxhoFZt8ABpron5YX2kziRaPZHSnzhsfEIeUctF8kQ6dZbWS8Cy6n+SLRjNsnNTw8lk6aFbITYRvNlQZ72Q1KNKIjefjWg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t06pi-0001cl-30 for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2024 18:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Oct 2024 22:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57627 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 57627-submit@debbugs.gnu.org id=B57627.17288575666200 (code B ref 57627); Sun, 13 Oct 2024 22:13:02 +0000 Original-Received: (at 57627) by debbugs.gnu.org; 13 Oct 2024 22:12:46 +0000 Original-Received: from localhost ([127.0.0.1]:59060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t06pR-0001bv-Ii for submit@debbugs.gnu.org; Sun, 13 Oct 2024 18:12:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t06pP-0001bV-DH for 57627@debbugs.gnu.org; Sun, 13 Oct 2024 18:12:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t06p3-0000sB-13; Sun, 13 Oct 2024 18:12:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=HdftYvKO/eZ7VPzm+dBzKcjaypocPKIvm1pZM2j7N9s=; b=k5tDH240cpXUV8GWt7eA KCfMpxBEPIu+b9gYTiRkdbA0FwUU1Tak/V+UTZJ9xoX344WNazLtq//Z/eypu0RkDIg0MzzEWqOG5 EmlCKut6UP35KOZhjRQnfWh81BSxnFwo4to9KT/9HE0+cj7cjALlRb2lpwZArOOceg4gAXPx8npoC PBaac3MR9miUXC4IKSADngvazChVdihWyaL10HT3x7xsA2PjB6S+ymnkXLwPaKsbaCxFmLPLOWkUf vP2zrjz8o+UxIE63nXSw7MWgDaizY6vLp2vpERCjSGFykPKej08Jqv/hBvADqN2Q3WhoSSHVg5hBL GYda1kJM7C9odw==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1t06p2-0005Es-Fu; Sun, 13 Oct 2024 18:12:20 -0400 In-Reply-To: (Andrea Corallo's message of "Sun, 13 Oct 2024 17:20:15 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293553 Archived-At: Andrea Corallo writes: > Eli Zaretskii writes: > >> Ping! > > Here I'm. > > I tried again reproducing the bug but with no success, maybe it depends > on the configuration? > > Anyway the following patch makes Phil test return (t t t t), essentially > if "file" ends with ".el.gz" we just remove the final ".gz" and keep the > previous logic. > [...] Ops, better to save the match data to avoid side effects: =================== modified lisp/emacs-lisp/comp-run.el @@ -143,20 +143,25 @@ native--compile-async-skip-p LOAD and SELECTOR work as described in `native--compile-async'." ;; Make sure we are not already compiling `file' (bug#40838). - (or (gethash file comp-async-compilations) - (gethash (file-name-with-extension file "elc") comp--no-native-compile) - (cond - ((null selector) nil) - ((functionp selector) (not (funcall selector file))) - ((stringp selector) (not (string-match-p selector file))) - (t (error "SELECTOR must be a function a regexp or nil"))) - ;; Also exclude files from deferred compilation if - ;; any of the regexps in - ;; `native-comp-jit-compilation-deny-list' matches. - (and (eq load 'late) - (seq-some (lambda (re) - (string-match-p re file)) - native-comp-jit-compilation-deny-list)))) + (let ((file (save-match-data + (if (string-match (rx (group-n 1 (one-or-more nonl) ".el") ".gz" eol) + file) + (match-string 1 file) + file)))) + (or (gethash file comp-async-compilations) + (gethash (file-name-with-extension file "elc") comp--no-native-compile) + (cond + ((null selector) nil) + ((functionp selector) (not (funcall selector file))) + ((stringp selector) (not (string-match-p selector file))) + (t (error "SELECTOR must be a function a regexp or nil"))) + ;; Also exclude files from deferred compilation if + ;; any of the regexps in + ;; `native-comp-jit-compilation-deny-list' matches. + (and (eq load 'late) + (seq-some (lambda (re) + (string-match-p re file)) + native-comp-jit-compilation-deny-list))))) (defvar comp-files-queue () "List of Emacs Lisp files to be compiled.") =========================== Andrea