From: Andrea Corallo <acorallo@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: psainty@orcon.net.nz, 57627@debbugs.gnu.org, larsi@gnus.org,
arash@gnu.org, monnier@iro.umontreal.ca
Subject: bug#57627: 29.0.50; [native-compilation] cl-loaddefs.el recompiled on startup
Date: Sun, 13 Oct 2024 18:12:19 -0400 [thread overview]
Message-ID: <yp1o73nveik.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <yp1seszvgxc.fsf@fencepost.gnu.org> (Andrea Corallo's message of "Sun, 13 Oct 2024 17:20:15 -0400")
Andrea Corallo <acorallo@gnu.org> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>> Ping!
>
> Here I'm.
>
> I tried again reproducing the bug but with no success, maybe it depends
> on the configuration?
>
> Anyway the following patch makes Phil test return (t t t t), essentially
> if "file" ends with ".el.gz" we just remove the final ".gz" and keep the
> previous logic.
>
[...]
Ops, better to save the match data to avoid side effects:
===================
modified lisp/emacs-lisp/comp-run.el
@@ -143,20 +143,25 @@ native--compile-async-skip-p
LOAD and SELECTOR work as described in `native--compile-async'."
;; Make sure we are not already compiling `file' (bug#40838).
- (or (gethash file comp-async-compilations)
- (gethash (file-name-with-extension file "elc") comp--no-native-compile)
- (cond
- ((null selector) nil)
- ((functionp selector) (not (funcall selector file)))
- ((stringp selector) (not (string-match-p selector file)))
- (t (error "SELECTOR must be a function a regexp or nil")))
- ;; Also exclude files from deferred compilation if
- ;; any of the regexps in
- ;; `native-comp-jit-compilation-deny-list' matches.
- (and (eq load 'late)
- (seq-some (lambda (re)
- (string-match-p re file))
- native-comp-jit-compilation-deny-list))))
+ (let ((file (save-match-data
+ (if (string-match (rx (group-n 1 (one-or-more nonl) ".el") ".gz" eol)
+ file)
+ (match-string 1 file)
+ file))))
+ (or (gethash file comp-async-compilations)
+ (gethash (file-name-with-extension file "elc") comp--no-native-compile)
+ (cond
+ ((null selector) nil)
+ ((functionp selector) (not (funcall selector file)))
+ ((stringp selector) (not (string-match-p selector file)))
+ (t (error "SELECTOR must be a function a regexp or nil")))
+ ;; Also exclude files from deferred compilation if
+ ;; any of the regexps in
+ ;; `native-comp-jit-compilation-deny-list' matches.
+ (and (eq load 'late)
+ (seq-some (lambda (re)
+ (string-match-p re file))
+ native-comp-jit-compilation-deny-list)))))
(defvar comp-files-queue ()
"List of Emacs Lisp files to be compiled.")
===========================
Andrea
next prev parent reply other threads:[~2024-10-13 22:12 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 11:38 bug#57627: 29.0.50; [native-compilation] cl-loaddefs.el recompiled on startup German Pacenza
2022-09-06 15:02 ` Lars Ingebrigtsen
2022-09-06 15:46 ` German Pacenza
2022-09-06 15:51 ` Lars Ingebrigtsen
2022-09-06 16:33 ` Andrea Corallo
2022-09-06 16:41 ` Eli Zaretskii
2022-09-06 19:23 ` Andrea Corallo
2022-09-06 20:40 ` Lars Ingebrigtsen
2022-09-07 2:33 ` Eli Zaretskii
2022-09-07 12:47 ` Lars Ingebrigtsen
2022-09-07 13:01 ` German Pacenza
2022-09-07 13:06 ` Lars Ingebrigtsen
2022-09-07 13:41 ` Lars Ingebrigtsen
2022-09-07 13:08 ` Eli Zaretskii
2022-09-07 13:10 ` Lars Ingebrigtsen
2022-09-07 18:06 ` Andrea Corallo
2022-09-08 11:57 ` Lars Ingebrigtsen
2022-09-09 12:57 ` Andrea Corallo
2022-09-09 17:09 ` Lars Ingebrigtsen
2022-09-09 19:03 ` Andrea Corallo
2022-09-10 4:33 ` Lars Ingebrigtsen
2022-09-10 4:38 ` Lars Ingebrigtsen
2022-10-14 10:53 ` Lars Ingebrigtsen
2022-10-14 19:00 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-15 10:13 ` Lars Ingebrigtsen
2022-10-15 14:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-16 8:21 ` Lars Ingebrigtsen
2022-10-17 7:47 ` Andrea Corallo
2022-10-17 8:49 ` Lars Ingebrigtsen
2022-10-17 8:52 ` Andrea Corallo
2022-10-17 9:06 ` Eli Zaretskii
2022-10-17 9:13 ` Lars Ingebrigtsen
2022-10-17 11:59 ` Arash Esbati
2022-10-17 12:01 ` Lars Ingebrigtsen
2022-10-17 12:09 ` Arash Esbati
2022-10-17 12:21 ` Lars Ingebrigtsen
2022-10-17 12:31 ` Lars Ingebrigtsen
2022-10-17 12:53 ` Arash Esbati
2022-10-17 12:59 ` German Pacenza
2024-08-28 2:04 ` Phil Sainty
2024-09-06 8:44 ` Andrea Corallo
2024-09-14 7:50 ` Eli Zaretskii
2024-09-14 12:13 ` Phil Sainty
2024-09-28 8:53 ` Eli Zaretskii
2024-10-12 11:21 ` Eli Zaretskii
2024-10-13 21:20 ` Andrea Corallo
2024-10-13 22:12 ` Andrea Corallo [this message]
2024-10-15 13:01 ` Phil Sainty
2024-10-15 19:20 ` Andrea Corallo
2024-10-15 19:56 ` Phil Sainty
2024-10-15 20:27 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yp1o73nveik.fsf@fencepost.gnu.org \
--to=acorallo@gnu.org \
--cc=57627@debbugs.gnu.org \
--cc=arash@gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
--cc=psainty@orcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).