bug#71916: 31.0.50; build failure on MINGW64

bug#71916: 31.0.50; build failure on MINGW64

[leuven65]

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

I found the latest version of both master and emacs-30 branch (from Monday)
failed to be built on MINGW64 / windows10.
It failed when starting native compilation, error pops up "Cannot find
libgccjit library" (from comp-ensure-native-compiler), maybe the called
function "load_gccjit_if_necessary / init_gccjit_functions" return error.

But if to revert the change introduced by branch
"savannah/scratch/windows-98" (merged on 2024/06/30), the build becomes OK.

> git revert 38179f85f8f7236d5de8d9a4333b6a1d4ded63f0

So that maybe the issue is caused by the 3 commits in this branch.

[-- Attachment #2: Type: text/html, Size: 887 bytes --]

bug#71916: 31.0.50; build failure on MINGW64

[Andrea Corallo]

leuven65 <leuven65@gmail.com> writes:

> I found the latest version of both master and emacs-30 branch (from Monday) failed to be built on MINGW64 / windows10.
> It failed when starting native compilation, error pops up "Cannot find libgccjit library" (from
> comp-ensure-native-compiler), maybe the called function "load_gccjit_if_necessary / init_gccjit_functions" return error.
>
> But if to revert the change introduced by branch "savannah/scratch/windows-98" (merged on 2024/06/30), the build becomes
> OK.
>
>  git revert 38179f85f8f7236d5de8d9a4333b6a1d4ded63f0
>
> So that maybe the issue is caused by the 3 commits in this branch.

Hello leuven65,

could you share the exact error you observe?

Ccing Po Lo

Thanks

  Andrea

bug#71916: 31.0.50; build failure on MINGW64

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Andrea Corallo <acorallo@gnu.org> writes:

> leuven65 <leuven65@gmail.com> writes:
>
>> I found the latest version of both master and emacs-30 branch (from Monday) failed to be built on MINGW64 / windows10.
>> It failed when starting native compilation, error pops up "Cannot find libgccjit library" (from
>> comp-ensure-native-compiler), maybe the called function "load_gccjit_if_necessary / init_gccjit_functions" return error.
>>
>> But if to revert the change introduced by branch "savannah/scratch/windows-98" (merged on 2024/06/30), the build becomes
>> OK.
>>
>>  git revert 38179f85f8f7236d5de8d9a4333b6a1d4ded63f0
>>
>> So that maybe the issue is caused by the 3 commits in this branch.
>
> Hello leuven65,
>
> could you share the exact error you observe?
>
> Ccing Po Lo
>
> Thanks
>
>   Andrea

Yes, please, thanks.

bug#71916: 31.0.50; build failure on MINGW64

[leuven65]

[-- Attachment #1: Type: text/plain, Size: 6807 bytes --]

* The installed MINGW64 packages
#+begin_quote
base-devel 2022.12-2
mingw-w64-x86_64-aspell-en 2020.12.07-1
mingw-w64-x86_64-autotools 2023.09.28-2
mingw-w64-x86_64-binutils 2.42-2
mingw-w64-x86_64-crt-git 12.0.0.r81.g90abf784a-1
mingw-w64-x86_64-diffutils 3.6-3
mingw-w64-x86_64-emacs-pdf-tools-server 1.1.0-1
mingw-w64-x86_64-gcc 14.1.0-3
mingw-w64-x86_64-gnupg 2.4.5-1
mingw-w64-x86_64-headers-git 12.0.0.r81.g90abf784a-1
mingw-w64-x86_64-jansson 2.14-2
mingw-w64-x86_64-libgccjit 14.1.0-3
mingw-w64-x86_64-librsvg 2.58.0-1
mingw-w64-x86_64-libvterm 0.3.3-1
mingw-w64-x86_64-libxml2 2.12.8-1
mingw-w64-x86_64-make 4.4.1-2
mingw-w64-x86_64-mpg123 1.32.6-1
mingw-w64-x86_64-pkgconf 1~2.2.0-1
mingw-w64-x86_64-rust 1.79.0-1
mingw-w64-x86_64-tools-git 12.0.0.r81.g90abf784a-1
mingw-w64-x86_64-tree-sitter 0.22.6-1
mingw-w64-x86_64-winpthreads-git 12.0.0.r81.g90abf784a-1
mingw-w64-x86_64-xpm-nox 4.2.0-8
#+end_quote

* The used commit on master branch
65bd41d1cf6d8ea6b95b69d9c60b0111a1c33392

* The build command
#+begin_src sh
  ./autogen.sh

  ./configure \
        --config-cache \
        --without-dbus \
        --without-pop \
        --without-compress-install \
        --with-native-compilation=aot \
        --with-tree-sitter \

  make -j$(nproc)
#+end_src

* Error pops up during building
#+begin_quote
make[3]: Entering directory '/c/workdir/emacs-src/lisp'
  ELC+ELN  emacs-lisp/macroexp.elc
  ELC+ELN  emacs-lisp/cconv.elc
  ELC+ELN  emacs-lisp/byte-opt.elc
  ELC+ELN  emacs-lisp/bytecomp.elc
  ELC+ELN  emacs-lisp/comp.elc
  ELC+ELN  emacs-lisp/comp-cstr.elc
  ELC+ELN  emacs-lisp/comp-common.elc
  ELC+ELN  emacs-lisp/comp-run.elc
  ELC+ELN  emacs-lisp/loaddefs-gen.elc

Error: error ("Cannot find libgccjit library")
  signal(error ("Cannot find libgccjit library"))
  error("Cannot find libgccjit library")
  comp-ensure-native-compiler()
  batch-byte+native-compile()
  funcall(batch-byte+native-compile)
  (if (commandp tem) (command-execute tem) (funcall tem))
  (cond ((setq tem (assoc argi command-switch-alist)) (if argval (let
((command-line-args-left (cons argval command-line-args-left))) (funcall
(cdr tem) argi)) (funcall (cdr tem) argi))) ((equal argi "-no-splash")
(setq inhibit-startup-screen t)) ((member argi '("-f" "-funcall" "-e"))
(setq inhibit-startup-screen t) (setq tem (intern (or argval (car-safe
(prog1 command-line-args-left (setq command-line-args-left (cdr
command-line-args-left))))))) (if (commandp tem) (command-execute tem)
(funcall tem))) ((member argi '("-eval" "-execute")) (setq
inhibit-startup-screen t) (let* ((str-expr (or argval (car-safe (prog1
command-line-args-left (setq command-line-args-left (cdr
command-line-args-left)))))) (read-data (read-from-string str-expr)) (expr
(car read-data)) (end (cdr read-data))) (if (string-match-p "[ \11\n]*\\'"
str-expr end) nil (error "Trailing garbage following expression: %s"
(substring str-expr end))) (eval expr t))) ((member argi '("-L"
"-directory")) (let (append) (if (string-match-p (format "\\`%s"
path-separator) (setq tem (or argval (car-safe (prog1
command-line-args-left (setq command-line-args-left (cdr
command-line-args-left))))))) (progn (setq tem (substring tem 1)) (setq
append t))) (setq tem (expand-file-name (command-line-normalize-file-name
tem))) (cond (append (setq load-path (append load-path (list tem))) (if
splice (setq splice load-path))) (splice (setcdr splice (cons tem (cdr
splice))) (setq splice (cdr splice))) (t (progn (setq load-path (cons tem
load-path)) (setq splice load-path)))))) ((member argi '("-l" "-load"))
(let* ((file (command-line-normalize-file-name (or argval (car-safe (prog1
command-line-args-left (setq command-line-args-left (cdr
command-line-args-left))))))) (file-ex (file-truename (expand-file-name
file)))) (if (file-regular-p file-ex) (progn (setq file file-ex))) (load
file nil t))) ((member argi '("-scriptload" "-scripteval")) (let* ((file
(command-line-normalize-file-name (or argval (car-safe (prog1
command-line-args-left (setq command-line-args-left (cdr
command-line-args-left))))))) (file-ex (expand-file-name file)) (truename
(file-truename file-ex))) (if (file-exists-p truename) (progn (setq file-ex
truename))) (if (equal argi "-scripteval") (command-line--eval-script
file-ex) (command-line--load-script file-ex)))) ((equal argi "-insert")
(setq inhibit-startup-screen t) (setq tem (or argval (car-safe (prog1
command-line-args-left (setq command-line-args-left (cdr
command-line-args-left)))))) (or (stringp tem) (error "File name omitted
from `-insert' option")) (insert-file-contents
(command-line-normalize-file-name tem))) ((or (equal argi "-dump-file")
(equal argi "-seccomp")) (or argval (car-safe (prog1 command-line-args-left
(setq command-line-args-left (cdr command-line-args-left)))))) ((equal argi
"-kill") (kill-emacs t)) ((equal argi "-no-desktop") (message
"\"--no-desktop\" ignored because the Desktop package is not loaded"))
((string-match "^\\+[0-9]+\\'" argi) (setq line (string-to-number argi)))
((string-match "^\\+\\([0-9]+\\):\\([0-9]+\\)\\'" argi) (progn (setq line
(string-to-number (match-string 1 argi))) (setq column (string-to-number
(match-string 2 argi))))) ((setq tem (assoc orig-argi
command-line-x-option-alist)) (setq command-line-args-left (nthcdr (nth 1
tem) command-line-args-left))) ((setq tem (assoc orig-argi
command-line-ns-option-alist)) (setq command-line-args-left (nthcdr (nth 1
tem) command-line-args-left))) ((member argi '("-find-file" "-file"
"-visit")) (setq inhibit-startup-screen t) (setq tem (or argval (car-safe
(prog1 command-line-args-left (setq command-line-args-left (cdr
command-line-args-left)))))) (if (stringp tem) nil (error "File name
omitted from `%s' option" argi)) (funcall process-file-arg tem))
((string-match "\\`--?\\(no-\\)?\\(uni\
#+end_quote

On Wed, Jul 3, 2024 at 3:52 PM Andrea Corallo <acorallo@gnu.org> wrote:

> leuven65 <leuven65@gmail.com> writes:
>
> > I found the latest version of both master and emacs-30 branch (from
> Monday) failed to be built on MINGW64 / windows10.
> > It failed when starting native compilation, error pops up "Cannot find
> libgccjit library" (from
> > comp-ensure-native-compiler), maybe the called function
> "load_gccjit_if_necessary / init_gccjit_functions" return error.
> >
> > But if to revert the change introduced by branch
> "savannah/scratch/windows-98" (merged on 2024/06/30), the build becomes
> > OK.
> >
> >  git revert 38179f85f8f7236d5de8d9a4333b6a1d4ded63f0
> >
> > So that maybe the issue is caused by the 3 commits in this branch.
>
> Hello leuven65,
>
> could you share the exact error you observe?
>
> Ccing Po Lo
>
> Thanks
>
>   Andrea
>

[-- Attachment #2: Type: text/html, Size: 7758 bytes --]

bug#71916: 31.0.50; build failure on MINGW64

[Andy Moreton]

On Wed 03 Jul 2024, Andrea Corallo wrote:

> leuven65 <leuven65@gmail.com> writes:
>
>> I found the latest version of both master and emacs-30 branch (from Monday) failed to be built on MINGW64 / windows10.
>> It failed when starting native compilation, error pops up "Cannot find libgccjit library" (from
>> comp-ensure-native-compiler), maybe the called function "load_gccjit_if_necessary / init_gccjit_functions" return error.
>>
>> But if to revert the change introduced by branch "savannah/scratch/windows-98" (merged on 2024/06/30), the build becomes
>> OK.
>>
>>  git revert 38179f85f8f7236d5de8d9a4333b6a1d4ded63f0
>>
>> So that maybe the issue is caused by the 3 commits in this branch.
>
> Hello leuven65,
>
> could you share the exact error you observe?
>
> Ccing Po Lo
>
> Thanks
>
>   Andrea

I've seen the same issue on emacs-30 and master branches. It seems to be
that emacs cannot find the libgccjit DLL after dumping.

Running emacs under gdb, and using a breakpoint on `redraw-display':

(gdb) r -Q
Starting program: C:\emacs\git\emacs\emacs-30\build\mingw64-x86_64-O2-native\src\emacs.exe -Q
[New Thread 11584.0x27b4]
[New Thread 11584.0x1f54]
[New Thread 11584.0x1ec8]
[New Thread 11584.0x2ad0]
[New Thread 11584.0x1a60]

Thread 1 hit Breakpoint 2, Fredraw_display () at C:/emacs/git/emacs/emacs-30/src/dispnew.c:3222

(gdb) pp Vlibrary_cache
((gccjit) (gccjit . t))

It seems odd that there are two entries here.

There is code at the end of syms_of_emacs in emacs.c that changes
Vdynamic_library_alist as a workaround for something similar, so have
other changes made that ineffective ?

    AndyM

bug#71916: 31.0.50; build failure on MINGW64

[Eli Zaretskii]

> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Wed, 03 Jul 2024 19:02:06 +0100
> 
> On Wed 03 Jul 2024, Andrea Corallo wrote:
> 
> > leuven65 <leuven65@gmail.com> writes:
> >
> >> I found the latest version of both master and emacs-30 branch (from Monday) failed to be built on MINGW64 / windows10.
> >> It failed when starting native compilation, error pops up "Cannot find libgccjit library" (from
> >> comp-ensure-native-compiler), maybe the called function "load_gccjit_if_necessary / init_gccjit_functions" return error.
> >>
> >> But if to revert the change introduced by branch "savannah/scratch/windows-98" (merged on 2024/06/30), the build becomes
> >> OK.
> >>
> >>  git revert 38179f85f8f7236d5de8d9a4333b6a1d4ded63f0
> >>
> >> So that maybe the issue is caused by the 3 commits in this branch.
> >
> > Hello leuven65,
> >
> > could you share the exact error you observe?
> >
> > Ccing Po Lo
> >
> > Thanks
> >
> >   Andrea
> 
> I've seen the same issue on emacs-30 and master branches. It seems to be
> that emacs cannot find the libgccjit DLL after dumping.
> 
> Running emacs under gdb, and using a breakpoint on `redraw-display':
> 
> (gdb) r -Q
> Starting program: C:\emacs\git\emacs\emacs-30\build\mingw64-x86_64-O2-native\src\emacs.exe -Q
> [New Thread 11584.0x27b4]
> [New Thread 11584.0x1f54]
> [New Thread 11584.0x1ec8]
> [New Thread 11584.0x2ad0]
> [New Thread 11584.0x1a60]
> 
> Thread 1 hit Breakpoint 2, Fredraw_display () at C:/emacs/git/emacs/emacs-30/src/dispnew.c:3222
> 
> (gdb) pp Vlibrary_cache
> ((gccjit) (gccjit . t))
> 
> It seems odd that there are two entries here.

Thanks, I think I fixed this now on the emacs-30 branch.

> There is code at the end of syms_of_emacs in emacs.c that changes
> Vdynamic_library_alist as a workaround for something similar, so have
> other changes made that ineffective ?

No, the problem was that Vlibrary_cache was not re-initialized after
loading the pdumper file.

bug#71916: 31.0.50; build failure on MINGW64

[Andy Moreton]

On Wed 03 Jul 2024, Eli Zaretskii wrote:

>> From: Andy Moreton <andrewjmoreton@gmail.com>
>> Date: Wed, 03 Jul 2024 19:02:06 +0100
>> 
>> On Wed 03 Jul 2024, Andrea Corallo wrote:
>> 
>> > leuven65 <leuven65@gmail.com> writes:
>> >
>> >> I found the latest version of both master and emacs-30 branch (from Monday) failed to be built on MINGW64 / windows10.
>> >> It failed when starting native compilation, error pops up "Cannot find libgccjit library" (from
>> >> comp-ensure-native-compiler), maybe the called function "load_gccjit_if_necessary / init_gccjit_functions" return error.
>> >>
>> >> But if to revert the change introduced by branch "savannah/scratch/windows-98" (merged on 2024/06/30), the build becomes
>> >> OK.
>> >>
>> >>  git revert 38179f85f8f7236d5de8d9a4333b6a1d4ded63f0
>> >>
>> >> So that maybe the issue is caused by the 3 commits in this branch.
>> >
>> > Hello leuven65,
>> >
>> > could you share the exact error you observe?
>> >
>> > Ccing Po Lo
>> >
>> > Thanks
>> >
>> >   Andrea
>> 
>> I've seen the same issue on emacs-30 and master branches. It seems to be
>> that emacs cannot find the libgccjit DLL after dumping.
>> 
>> Running emacs under gdb, and using a breakpoint on `redraw-display':
>> 
>> (gdb) r -Q
>> Starting program: C:\emacs\git\emacs\emacs-30\build\mingw64-x86_64-O2-native\src\emacs.exe -Q
>> [New Thread 11584.0x27b4]
>> [New Thread 11584.0x1f54]
>> [New Thread 11584.0x1ec8]
>> [New Thread 11584.0x2ad0]
>> [New Thread 11584.0x1a60]
>> 
>> Thread 1 hit Breakpoint 2, Fredraw_display () at C:/emacs/git/emacs/emacs-30/src/dispnew.c:3222
>> 
>> (gdb) pp Vlibrary_cache
>> ((gccjit) (gccjit . t))
>> 
>> It seems odd that there are two entries here.
>
> Thanks, I think I fixed this now on the emacs-30 branch.
>
>> There is code at the end of syms_of_emacs in emacs.c that changes
>> Vdynamic_library_alist as a workaround for something similar, so have
>> other changes made that ineffective ?
>
> No, the problem was that Vlibrary_cache was not re-initialized after
> loading the pdumper file.

Thanks Eli, confirmed as working again on emacs-30.

    AndyM

bug#71916: 31.0.50; build failure on MINGW64

[Andrea Corallo]

Andy Moreton <andrewjmoreton@gmail.com> writes:

> On Wed 03 Jul 2024, Eli Zaretskii wrote:
>
>>> From: Andy Moreton <andrewjmoreton@gmail.com>
>>> Date: Wed, 03 Jul 2024 19:02:06 +0100
>>> 
>>> On Wed 03 Jul 2024, Andrea Corallo wrote:
>>> 
>>> > leuven65 <leuven65@gmail.com> writes:
>>> >
>>> >> I found the latest version of both master and emacs-30 branch (from Monday) failed to be built on MINGW64 / windows10.
>>> >> It failed when starting native compilation, error pops up "Cannot find libgccjit library" (from
>>> >> comp-ensure-native-compiler), maybe the called function "load_gccjit_if_necessary / init_gccjit_functions" return error.
>>> >>
>>> >> But if to revert the change introduced by branch "savannah/scratch/windows-98" (merged on 2024/06/30), the build becomes
>>> >> OK.
>>> >>
>>> >>  git revert 38179f85f8f7236d5de8d9a4333b6a1d4ded63f0
>>> >>
>>> >> So that maybe the issue is caused by the 3 commits in this branch.
>>> >
>>> > Hello leuven65,
>>> >
>>> > could you share the exact error you observe?
>>> >
>>> > Ccing Po Lo
>>> >
>>> > Thanks
>>> >
>>> >   Andrea
>>> 
>>> I've seen the same issue on emacs-30 and master branches. It seems to be
>>> that emacs cannot find the libgccjit DLL after dumping.
>>> 
>>> Running emacs under gdb, and using a breakpoint on `redraw-display':
>>> 
>>> (gdb) r -Q
>>> Starting program: C:\emacs\git\emacs\emacs-30\build\mingw64-x86_64-O2-native\src\emacs.exe -Q
>>> [New Thread 11584.0x27b4]
>>> [New Thread 11584.0x1f54]
>>> [New Thread 11584.0x1ec8]
>>> [New Thread 11584.0x2ad0]
>>> [New Thread 11584.0x1a60]
>>> 
>>> Thread 1 hit Breakpoint 2, Fredraw_display () at C:/emacs/git/emacs/emacs-30/src/dispnew.c:3222
>>> 
>>> (gdb) pp Vlibrary_cache
>>> ((gccjit) (gccjit . t))
>>> 
>>> It seems odd that there are two entries here.
>>
>> Thanks, I think I fixed this now on the emacs-30 branch.
>>
>>> There is code at the end of syms_of_emacs in emacs.c that changes
>>> Vdynamic_library_alist as a workaround for something similar, so have
>>> other changes made that ineffective ?
>>
>> No, the problem was that Vlibrary_cache was not re-initialized after
>> loading the pdumper file.
>
> Thanks Eli, confirmed as working again on emacs-30.
>
>     AndyM

Thanks closing.