From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#75135: 30.0.93; Infinite loop in comp--native-compile Date: Sun, 29 Dec 2024 09:23:19 -0500 Message-ID: References: <87msgiasma.fsf@klaatu.mail-host-address-is-not-set> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30844"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 75135@debbugs.gnu.org, Eli Zaretskii To: Hugh Daschbach Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 29 15:24:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tRuDV-0007r6-Qg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Dec 2024 15:24:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRuD8-0007Nw-T8; Sun, 29 Dec 2024 09:24:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRuD5-0007Ng-Dd for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2024 09:24:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tRuD5-0008T3-4g for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2024 09:24:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=czlQ7Jn4Bg3Q3pYv48eJPm2tfORJs2d783DiB7VCqlU=; b=g1gMTdGoKgdE0mjgVRQhITl5bauHEA4OOzCtHZIMTeTadhUAOam1IIKF5/y+I2af3kteTPduZUBc7ipxC99I+Oq/AwG4TuEpsRmpTc1RepTFWTxOwHF1UMfP3PlE44IedACPoqx/STUKs5wd34Oy8uGgMCmBbWdXu+a3CG0rQPAi1f8AjKiuR+PLVw8O4t1zoSif1gpL7W6O44DQe7aXbi5cqyjA6e0RXxpNtxBNizbgN+RDEturZYdVjUtjG3cd3Y6VFm1CbhfcinFXiFrAr1wbJuotXOSVEaozcNLhP720Nf7b02/lAHQCk+rwqw4+fXrp6RE9HdE8UcuEiwdQtg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tRuD3-0002IQ-Ok for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2024 09:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Dec 2024 14:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75135 X-GNU-PR-Package: emacs Original-Received: via spool by 75135-submit@debbugs.gnu.org id=B75135.17354822108787 (code B ref 75135); Sun, 29 Dec 2024 14:24:01 +0000 Original-Received: (at 75135) by debbugs.gnu.org; 29 Dec 2024 14:23:30 +0000 Original-Received: from localhost ([127.0.0.1]:54256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRuCY-0002He-12 for submit@debbugs.gnu.org; Sun, 29 Dec 2024 09:23:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRuCT-0002HL-Ry for 75135@debbugs.gnu.org; Sun, 29 Dec 2024 09:23:27 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRuCO-0008QX-F5; Sun, 29 Dec 2024 09:23:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=czlQ7Jn4Bg3Q3pYv48eJPm2tfORJs2d783DiB7VCqlU=; b=Clec22rwdA+ukoY8wwMC dKW9eQwAdJO8sW98LNnuRDsyGH5W4BW3jmx09XtDq/C/zlAHr60BYVyVRaxw0EeATRAnR7c4b/hjR Iw8QxfvX7Qmx7RnSOdU5dJM/mnaY49f7ItKKOZV3T9KoL3j0AOyapV8p0FUv4U+Hck5Jk1rqKPSgy 7VWfjkTxXhXfLQUuLQZq5KF6bTghciQty1LndGrkfDzyVL3USRdW4blnY0oVgBhdSXeU/RrxqhjRQ qvutN2tSaJgZn2bTuNoG2QbIwyvQL1xTRqGsKz3dFA//cuAsgy0scW3bAyAVYpTUkz/SrgZEa/Opo CRBgDtkLWVLsiw==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1tRuCN-0006Eh-Cw; Sun, 29 Dec 2024 09:23:20 -0500 In-Reply-To: (Andrea Corallo's message of "Sun, 29 Dec 2024 05:17:10 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297945 Archived-At: --=-=-= Content-Type: text/plain The attached should be fixing it, could you give it a try? Circular objects are rare in code and we lived with this for a long time, I'd suggest to install this only on master not to touch the release branch. Eli WDYT? Thanks Andrea --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=circ.patch diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el index 2966ed255ac..f3b6b8fd606 100644 --- a/lisp/emacs-lisp/comp.el +++ b/lisp/emacs-lisp/comp.el @@ -2481,8 +2481,9 @@ comp--ssa-rename-insn (setf (comp-vec-aref frame slot-n) mvar (cadr insn) mvar)))) (pcase insn - (`(setimm ,(pred targetp) ,_imm) - (new-lvalue)) + (`(setimm ,lval ,_imm) + (when (targetp lval) + (new-lvalue))) (`(,(pred comp--assign-op-p) ,(pred targetp) . ,_) (let ((mvar (comp-vec-aref frame slot-n))) (setf (cddr insn) (cl-nsubst-if mvar #'targetp (cddr insn)))) --=-=-=--