unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrea Corallo <acorallo@gnu.org>
To: Hugh Daschbach <hdasch@ccss.com>
Cc: 75135@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#75135: 30.0.93; Infinite loop in comp--native-compile
Date: Sun, 29 Dec 2024 09:23:19 -0500	[thread overview]
Message-ID: <yp1jzbi7elk.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <yp1wmfi7pzt.fsf@fencepost.gnu.org> (Andrea Corallo's message of "Sun, 29 Dec 2024 05:17:10 -0500")

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

The attached should be fixing it, could you give it a try?

Circular objects are rare in code and we lived with this for a long
time, I'd suggest to install this only on master not to touch the
release branch.  Eli WDYT?

Thanks

  Andrea


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: circ.patch --]
[-- Type: text/x-diff, Size: 660 bytes --]

diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index 2966ed255ac..f3b6b8fd606 100644
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -2481,8 +2481,9 @@ comp--ssa-rename-insn
                  (setf (comp-vec-aref frame slot-n) mvar
                        (cadr insn) mvar))))
      (pcase insn
-       (`(setimm ,(pred targetp) ,_imm)
-        (new-lvalue))
+       (`(setimm ,lval ,_imm)
+        (when (targetp lval)
+          (new-lvalue)))
        (`(,(pred comp--assign-op-p) ,(pred targetp) . ,_)
         (let ((mvar (comp-vec-aref frame slot-n)))
           (setf (cddr insn) (cl-nsubst-if mvar #'targetp (cddr insn))))

  reply	other threads:[~2024-12-29 14:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-27  0:15 bug#75135: 30.0.93; Infinite loop in comp--native-compile Hugh Daschbach
2024-12-29 10:17 ` Andrea Corallo
2024-12-29 14:23   ` Andrea Corallo [this message]
2024-12-29 14:28     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yp1jzbi7elk.fsf@fencepost.gnu.org \
    --to=acorallo@gnu.org \
    --cc=75135@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=hdasch@ccss.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).