From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log* Date: Wed, 05 Jul 2023 10:47:47 -0400 Message-ID: References: <87sfa44ixh.fsf@gmail.com> <83zg4ckki0.fsf@gnu.org> <87bkgr48qy.fsf@gmail.com> <83lefuk3b7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5940"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 64452@debbugs.gnu.org, No Wayman , monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 05 16:48:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qH3nv-0001K0-VI for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Jul 2023 16:48:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qH3nY-0006Bn-2I; Wed, 05 Jul 2023 10:48:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH3nX-0006BL-3H for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2023 10:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qH3nW-0003i8-RO for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2023 10:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qH3nW-0000Gc-BB for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2023 10:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jul 2023 14:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64452-submit@debbugs.gnu.org id=B64452.1688568477994 (code B ref 64452); Wed, 05 Jul 2023 14:48:02 +0000 Original-Received: (at 64452) by debbugs.gnu.org; 5 Jul 2023 14:47:57 +0000 Original-Received: from localhost ([127.0.0.1]:38769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH3nR-0000Fw-IR for submit@debbugs.gnu.org; Wed, 05 Jul 2023 10:47:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH3nP-0000F7-M5 for 64452@debbugs.gnu.org; Wed, 05 Jul 2023 10:47:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH3nJ-0003ha-BD; Wed, 05 Jul 2023 10:47:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=r5Oqcx5d1D1NlFZqTu2wH07ZwNHZVq1Zup/iE+Pf9SQ=; b=jvNfElyz7pI+OcCbMK8X mWELhfumcxQc5VvnjRTZuH4aeUut5Rz9Va8Epvqyec/J/4dTmaIx6WZtDWAiBWEfXjKzzsG5EaIgD uRl05TYXJYRJKSCa1J0kHe4wi/ygC2dV1itbpWy3HOjYgh0SCs91RPBvea7zqotkszFP4lRMzp4gR 8H4TJei9+vcZs6Y+p+giywycv78s/8vVICGUPoUahlnFtZy3U/LbktfWdQgoJhh+c2YdfCpYXMsrf Sih/+Rjm/JJ4tKLxJAvb0TlX3Hl881gGmZ+KbNaYzael1Wa+whnOWlLiZ7gPLVQfYYLQqLKOnhzk7 N5VriHoKnpx0CQ==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1qH3nH-0002cw-Ks; Wed, 05 Jul 2023 10:47:48 -0400 In-Reply-To: <83lefuk3b7.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 05 Jul 2023 14:25:48 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264637 Archived-At: Eli Zaretskii writes: >> From: No Wayman >> Cc: Andrea Corallo , Stefan Monnier >> , 64452@debbugs.gnu.org >> Date: Tue, 04 Jul 2023 18:21:00 -0400 >> >> Eli Zaretskii writes: >> >> > Thanks, but why not elisp-compile-mode, like we do in >> > *Compile-log* >> > buffers for byte compilation? >> >> Works for me. Revision attached. >> >> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el >> index 22fb08e4688..5f42d10407f 100644 >> --- a/lisp/emacs-lisp/comp.el >> +++ b/lisp/emacs-lisp/comp.el >> @@ -1133,7 +1133,8 @@ comp-log-to-buffer >> (log-buffer >> (or (get-buffer comp-log-buffer-name) >> (with-current-buffer (get-buffer-create comp-log-buffer-name) >> - (setf buffer-read-only t) >> + (unless (derived-mode-p 'emacs-lisp-compilation-mode) >> + (emacs-lisp-compilation-mode)) > > bytecomp.el uses > > (unless (derived-mode-p 'compilation-mode) > (emacs-lisp-compilation-mode)) > > Isn't that better? > > Also, do we really need to do this twice in comp-run-async-workers? > > Andrea, any comments? No, haven't tried it but it LGTM form here. Bests Andrea