From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#67005: 30.0.50; improve nadivce/comp/trampoline handling Date: Tue, 05 Dec 2023 12:09:33 -0500 Message-ID: References: <874jhv9921.fsf@sappc2.fritz.box> <875y24zrt1.fsf@sappc2.fritz.box> <87ttpmwuxi.fsf@sappc2.fritz.box> <877cmct4a1.fsf@sappc2.fritz.box> <87bkbmiwpf.fsf@sappc2.fritz.box> <87leap8n1z.fsf@sappc2.fritz.box> <87leaob192.fsf@sappc2.fritz.box> <871qcegg43.fsf@sappc2.fritz.box> <87plzxu1ea.fsf@vodafonemail.de> <87ttoxu3wh.fsf@sappc2.fritz.box> <86o7f5jzay.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2394"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 67005@debbugs.gnu.org To: Andy Moreton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 05 18:10:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAYw5-0000PI-1Z for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Dec 2023 18:10:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rAYvh-0005zr-Id; Tue, 05 Dec 2023 12:09:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAYvf-0005yQ-IG for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2023 12:09:51 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rAYvf-000739-98 for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2023 12:09:51 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rAYvq-00016E-6R for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2023 12:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Dec 2023 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67005 X-GNU-PR-Package: emacs Original-Received: via spool by 67005-submit@debbugs.gnu.org id=B67005.17017961984212 (code B ref 67005); Tue, 05 Dec 2023 17:10:02 +0000 Original-Received: (at 67005) by debbugs.gnu.org; 5 Dec 2023 17:09:58 +0000 Original-Received: from localhost ([127.0.0.1]:38255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAYvm-00015s-7G for submit@debbugs.gnu.org; Tue, 05 Dec 2023 12:09:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAYvh-00015a-IE for 67005@debbugs.gnu.org; Tue, 05 Dec 2023 12:09:57 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAYvP-00070b-G5; Tue, 05 Dec 2023 12:09:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=NsFN7ax3dxyIX87k4IzwE6wkWg9/pGzoyzxjL9uXDI4=; b=RTQt+BjPGM402smMO+Bb dp0dsPrcydO9I4XreyEpcGBykmyEkPs/KA6oNrMIFvCMSO6CdID4B8mRgH2KO1/4ct4JsI0MuoZi1 dOqEk1YbNmkHLQC35koNL2113gOYEH1PQAlr6KD0//eiTy/zhPcTsKAY+KfPMu4Htp1DHRYgd0vZs jyZ17zftX40Ftx2eEfpTK802BNLA3CCbwlbayEng9ojRkEh4/xXRErrJ9wXv9Qpy3jzlZkQun6JAM 6EilIIdWF9I9LRsTNsDLkWcAvmEuJBM/CeUwy3CHF0B/GBMmrTbdzdo7PBzlMaWYjQJ2QsWoe5Syk 1zn/fc3VAuXSLQ==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1rAYvN-0000Jv-7i; Tue, 05 Dec 2023 12:09:35 -0500 In-Reply-To: <86o7f5jzay.fsf@gmail.com> (Andy Moreton's message of "Mon, 04 Dec 2023 23:57:57 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275571 Archived-At: Andy Moreton writes: > On Mon 04 Dec 2023, Andrea Corallo wrote: > >> Jens Schmidt writes: >> >>> Jens Schmidt writes: >>> >>>> Patch reworked accordingly, also to include the additional commit >>>> message Andreas has proposed. Please review. >>> >>> 10 days (inclusive) have passed, so: Gentle Bump. Is there anything >>> still missing here? >>> >>> Thanks Jens >> >> Hi Jens, >> >> I've installed your patch into master with e670412a3e1. >> >> I'm closing the bug as well, happy to re-poen if necessary. >> >> Thanks >> >> Andrea > > Commit e670412a3e10 ("Update handling of advices during preload") > appears to break bootstrap on Windows with the 64bit mingw64 > toolchain: > > Error: error ("Preload advice on insert-directory") > mapbacktrace((closure ((prin1 . cl-prin1) t) (evald func args _flags) (let ((args args)) (if evald (progn (princ " ") (funcall prin1 func) (princ "(")) (progn (princ " ( > ") (setq args (cons func args)))) (if args (while (progn (funcall prin1 (car args)) (setq args (cdr args)))(princ " "))) (princ ")\n")))) > (let ((print-escape-newlines t) (print-escape-control-characters t) (print-escape-nonascii t) (prin1 (if (and (fboundp 'cl-prin1) (fboundp 'cl-defmethod) (condition-case n > il (require 'cl-print) (error nil))) #'cl-prin1 #'prin1))) (mapbacktrace #'(lambda (evald func args _flags) (let ((args args)) (if evald (progn (princ " ") (funcall prin1 f > unc) (princ "(")) (progn (princ " (") (setq args (cons func args)))) (if args (while (progn (funcall prin1 (car args)) (setq args (cdr args))) (princ " "))) (princ ")\n"))) > )) > debug-early-backtrace() > debug-early(error (error "Preload advice on insert-directory")) > signal(error ("Preload advice on insert-directory")) > error("Preload advice on %s" insert-directory) > (and (advice--p (symbol-function f)) (error "Preload advice on %s" f)) > (closure (t) (f) (and (advice--p (symbol-function f)) (error "Preload advice on %s" f)))(insert-directory) > mapatoms((closure(t) (f) (and (advice--p (symbol-function f)) (error "Preload advice on %s" f)))) > load("loadup.el") > Preload advice on insert-directory > make[2]: *** [Makefile:1014: bootstrap-emacs.pdmp] Error 127 > make[1]: *** [Makefile:554: src] Error 2 > > Bootstrapping the same config with commit f5e45247081a ("comp: Fix mvar > dependency chain (bug#67239)") succeeds. > > Both builds done from a clean checkout after "git clean -xdf". > > AndyM Hi Andy, thanks for reporting, is e670412a3e1 fixing this for you? Andrea