From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#72004: 30.0.50, master: 'erc--check-prompt-input-for-multiline-blanks' test fail Date: Fri, 12 Jul 2024 03:30:55 -0400 Message-ID: References: <86o776ztb9.fsf@gnu.org> <87cynkv1yf.fsf@neverwas.me> <87bk33ss3c.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7159"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-erc@gnu.org, 72004-done@debbugs.gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 12 09:32:42 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sSAlk-0001fo-Q2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Jul 2024 09:32:41 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sSAlF-0003Pj-0C; Fri, 12 Jul 2024 03:32:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSAl9-0003Nc-BN for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2024 03:32:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sSAl8-00031E-6o for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2024 03:32:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sSAl8-0002yB-90 for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2024 03:32:02 -0400 Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Jul 2024 07:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 72004 X-GNU-PR-Package: emacs Mail-Followup-To: 72004@debbugs.gnu.org, acorallo@gnu.org, acorallo@gnu.org Original-Received: via spool by 72004-done@debbugs.gnu.org id=D72004.172076947011352 (code D ref 72004); Fri, 12 Jul 2024 07:32:02 +0000 Original-Received: (at 72004-done) by debbugs.gnu.org; 12 Jul 2024 07:31:10 +0000 Original-Received: from localhost ([127.0.0.1]:53127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSAkF-0002x0-9L for submit@debbugs.gnu.org; Fri, 12 Jul 2024 03:31:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSAkA-0002wT-Ip for 72004-done@debbugs.gnu.org; Fri, 12 Jul 2024 03:31:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSAk4-0002WO-L4; Fri, 12 Jul 2024 03:30:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=LZARieNuqy2dIyy3u/0nlzmbaqQ9JJLSawSXLRL+Avg=; b=A8O3KJ0hD0yKcTopK1bB vS8EQilf0m/SDpc54bEcUkzjJ6qNa8i1npWM69Yb9QS26Zs9p8bUkEewxddsguMQUFBOCH8C0o7u7 sa1CZFMHBGFGzV6ZoQYkD2zl/5f352iRli+6jdPqiffFccippuGuQShcUWjW3ppcEsUDY61hJIe+s BUwUsFqQuSM3u1WK4ftGtOmeRhDtgOPnkzoB/YlePKS9mGIFFhK2DDR0xrbUAwL+FXLsXe9T8CsBD ZMyL/sKq03RPCksxRoder0iB+586Jc6jUpWtO6lmgvkE7IOk4N3cy5jhUjKbJxdEtRL7/qUQWYO32 jVh8PLPQO6415A==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sSAk3-0003wt-Ln; Fri, 12 Jul 2024 03:30:55 -0400 In-Reply-To: <87bk33ss3c.fsf@neverwas.me> (J. P.'s message of "Thu, 11 Jul 2024 11:26:15 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288765 Archived-At: "J.P." writes: > Andrea Corallo writes: > >> I buy the theory of this being related to trampoline generation under >> high system load, looking at my logs I see this test failing only with >> native compilation an passing without. >> >> I'm wondering if we could work around the issue somehow =F0=9F=A4=94 > > I'm afraid I can offer next to nothing when it comes to serious insights > about Emacs internals and related magic =F0=9F=98=9E > >> >> Also I'm not sure the right tag is :expensive, shouldn't be :unstable? > > If we want to prevent the test from running completely (at least on > EMBA), then :unstable would indeed make sense. However, if we'd like the > test to run on the 3x daily expensive pipelines, I'm fairly confident my > latest change sidesteps the issue. It now waits to start the subprocess, > which was previously too short-lived, until after the macro has done its > (potentially time-consuming) advising. Thus, the liveliness check that > was signaling the error should now always find a running process. > (Although, for good measure, I also lengthened the timeout from 10s to > 5m.) All this said, I'm happy to change it to :unstable or try a safer > approach, such as mocking `process-status'. Thanks. Generally speaking I think we should flag tests for what they are and then tune the EMBA testing strategy to our needs afterward. That said with a 5m timeout the test is now probably more expansive than unstable so I think the classificaiton it's fine :) Thanks closing this. Andrea