From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#67005: 30.0.50; improve nadivce/comp/trampoline handling Date: Thu, 23 Nov 2023 15:21:34 -0500 Message-ID: References: <874jhv9921.fsf@sappc2.fritz.box> <875y24zrt1.fsf@sappc2.fritz.box> <87ttpmwuxi.fsf@sappc2.fritz.box> <877cmct4a1.fsf@sappc2.fritz.box> <87bkbmiwpf.fsf@sappc2.fritz.box> <87leap8n1z.fsf@sappc2.fritz.box> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26183"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jens Schmidt , 67005@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 23 21:22:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6GDM-0006Xt-GE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Nov 2023 21:22:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6GD1-0002hW-R6; Thu, 23 Nov 2023 15:21:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6GD1-0002hN-8d for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2023 15:21:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6GD1-0003gu-0Q for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2023 15:21:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r6GD4-0004r9-J7 for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2023 15:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Nov 2023 20:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67005 X-GNU-PR-Package: emacs Original-Received: via spool by 67005-submit@debbugs.gnu.org id=B67005.170077090818642 (code B ref 67005); Thu, 23 Nov 2023 20:22:02 +0000 Original-Received: (at 67005) by debbugs.gnu.org; 23 Nov 2023 20:21:48 +0000 Original-Received: from localhost ([127.0.0.1]:35180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6GCp-0004qb-V7 for submit@debbugs.gnu.org; Thu, 23 Nov 2023 15:21:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6GCn-0004qN-6H for 67005@debbugs.gnu.org; Thu, 23 Nov 2023 15:21:46 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6GCd-0003fE-1f; Thu, 23 Nov 2023 15:21:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Ajzzaf76UocoEIqerRlJFgi0TOAeMdLm3QuFqYtyFno=; b=dSPQJsF2NhpV656gYNnO URkgItwu9/FLzLg/9SZXuuprCC8UEqOMX70XakxdgzHc58EQIDL8YMvVh07XafFtAcjpraq3gyAnc 0zdivdbsiAhRrZDdp+e1ufEPpXvK/06mhVLTntcNmMC4IRaD/fshB94F+tEb7E48itcQlcTKr7qy/ HRZuS4fGUx4nfHg0AFUPFek7AVkYZ2rHBvui4kK/zHtXRzCMjuka4Ir7MQCHrOD8uKL22cwHa1D1M gw15+oRxRE0Scx1UDQ+jue/ipMTZfuZQtll2y/y2YeW4TdZFn22Ux7JUGeIIsPzYoOkXzUZ2m9phT 4PpVfvso0d6WwA==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1r6GCc-0008Iz-Rw; Thu, 23 Nov 2023 15:21:34 -0500 In-Reply-To: (Stefan Monnier's message of "Thu, 23 Nov 2023 11:38:54 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274828 Archived-At: Stefan Monnier writes: >>>> + (when purify-flag >>>> + (error "Invalid pre-dump advice on %s" symbol)) >>>> (let* ((f (symbol-function symbol)) >>>> (nf (advice--normalize symbol f))) >>>> (unless (eq f nf) (fset symbol nf)) >>> >>> The patch LGTM thanks, just one question: should we guard in advice.el >>> as well just to stay on the safe side? >> >> Since `defadvice` is now marked as obsolete, it seems highly unlikely >> that we'd end up adding an old-style advice to a preloaded file. > > More to the point: no it's not necessary since `advice.el` uses > `advice-add` to install its pieces of advice, so the test in > `nadvice.el` already covers it. Great thanks for clarifying. Regards Andrea