From: Andrea Corallo <acorallo@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Eli Zaretskii <eliz@gnu.org>, 67141@debbugs.gnu.org
Subject: bug#67141: 30.0.50; Missing element in the backtrace
Date: Mon, 20 Nov 2023 03:55:40 -0500 [thread overview]
Message-ID: <yp15y1w6bxv.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <jwvsf54gjn5.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 17 Nov 2023 16:29:27 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> It impacts debugging and profiling, in my experience.
>> I see, the outcome for me is that we should offer a way for the user to
>> force the use of funcall. Unfortunatelly ATM if one writes like
>> (funcall 'eval ...) it gets optimized. Maybe even a funcall wrapper
>> written in Elisp would be sufficient?
>
> FWIW, for the specific example in the bug report, I'd argue that we
> should never call `Feval` directly because a call to `eval`
> is a pretty strong hint that speed is probably not a priority.
> Similarly I'd expect that most calls to `mapcar` won't benefit very much
> from a direct call because the cost of preparing the call
> (constructing a closure to pass to `mapcar`) and running the loop is
> probably high enough to dwarf the function call itself.
Good points,
With ea7a52dbaed I added eval to 'native-comp-never-optimize-functions'
so this should fix the reported issue, for mapcar I think we should
prove it has really no performance impact before deciding to include it
as well.
Thanks
Andrea
next prev parent reply other threads:[~2023-11-20 8:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-12 22:29 bug#67141: 30.0.50; Missing element in the backtrace Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-13 14:03 ` Eli Zaretskii
2023-11-13 16:27 ` Andrea Corallo
2023-11-16 9:35 ` Andrea Corallo
2023-11-17 19:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-17 20:48 ` Andrea Corallo
2023-11-17 21:29 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-20 8:55 ` Andrea Corallo [this message]
2023-11-20 12:12 ` Eli Zaretskii
2023-11-20 13:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-20 15:13 ` Andrea Corallo
2023-11-20 17:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-20 18:16 ` Andrea Corallo
2023-11-20 18:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-20 21:01 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yp15y1w6bxv.fsf@fencepost.gnu.org \
--to=acorallo@gnu.org \
--cc=67141@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).