From: Andrea Corallo <acorallo@gnu.org>
To: Chang Xiaoduan <drcxd@sina.com>
Cc: 67900@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#67900: 30.0.50; Emacs Crahes When Executing Command `consult-buffer'
Date: Fri, 29 Dec 2023 13:37:23 -0500 [thread overview]
Message-ID: <yp15y0gzwgs.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <m3sf3mmtzr.fsf@sina.com> (Chang Xiaoduan's message of "Thu, 28 Dec 2023 19:44:40 +0800")
Chang Xiaoduan <drcxd@sina.com> writes:
> Andrea Corallo <acorallo@gnu.org> writes:
>
>> Eli Zaretskii <eliz@gnu.org> writes:
>> I think the next step is to narrow down the miss-compiled function. For
>> that we can tweak speed on function basis like:
>>
>> (defun foo (x y)
>> (declare (speed 1))
>> (+ x y))
>>
>> As usual I'd start probing the suspect function `consult-buffer` and if
>> we find is not the coolprint I'd probably bisect all the functions in
>> the compilation unit.
>>
>> Thanks
>>
>> Andrea
>
> I have done this differently: I use an Emacs compiled with
> `native-comp-speed` set to 1. Then I add the `declare` form to all the
> `defun`, `cl-defun`, `defmacro` and `defsubst`, for example:
>
> ```
> (defun consult--customize-put (cmds prop form)
> "Set property PROP to FORM of commands CMDS."
> (declare (speed 2))
> (dolist (cmd cmds)
> (cond
> ((and (boundp cmd) (consp (symbol-value cmd)))
> (setf (plist-get (symbol-value cmd) prop) (eval form 'lexical)))
> ((functionp cmd)
> (setf (plist-get (alist-get cmd consult--customize-alist) prop) form))
> (t (user-error "%s is neither a Command command nor a source" cmd))))
> nil)
> ```
>
> With this setup I can not reproduce the crash. Is the method wrong? How?
> Can you explain this to me?
>
> Thank you
There could be some function generated by macros without the speed
declaration? Dunno...
Anyway please try the opposite strategy (CU at speed 2 and functions at
speed 1) to narrow the function and let us know if it's more successful.
Thanks
Andrea
next prev parent reply other threads:[~2023-12-29 18:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 7:48 bug#67900: 30.0.50; Emacs Crahes When Executing Command `consult-buffer' Chang Xiaoduan
2023-12-19 13:16 ` Eli Zaretskii
[not found] ` <m3msu5751x.fsf@sina.com>
2023-12-20 13:10 ` Eli Zaretskii
2023-12-21 3:26 ` Chang Xiaoduan
2023-12-21 8:02 ` Eli Zaretskii
2023-12-21 12:40 ` Andrea Corallo
2023-12-22 3:44 ` Chang Xiaoduan
2023-12-22 7:41 ` Eli Zaretskii
2023-12-22 9:38 ` Andrea Corallo
2023-12-23 2:30 ` Chang Xiaoduan
2023-12-23 7:35 ` Eli Zaretskii
2023-12-26 8:32 ` Andrea Corallo
2023-12-28 11:44 ` Chang Xiaoduan
2023-12-29 18:37 ` Andrea Corallo [this message]
2024-01-02 7:24 ` Chang Xiaoduan
2024-01-04 9:51 ` Andrea Corallo
2024-01-05 7:04 ` Chang Xiaoduan
2024-01-05 21:46 ` Andrea Corallo
2024-01-08 3:28 ` Chang Xiaoduan
2024-01-08 10:35 ` Andrea Corallo
2024-01-08 11:40 ` Chang Xiaoduan
2024-01-09 9:58 ` Andrea Corallo
2024-01-02 8:20 ` Chang Xiaoduan
2024-01-04 9:58 ` Andrea Corallo
2024-01-05 4:22 ` Richard Stallman
2024-01-05 7:09 ` Chang Xiaoduan
2024-01-07 4:29 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yp15y0gzwgs.fsf@fencepost.gnu.org \
--to=acorallo@gnu.org \
--cc=67900@debbugs.gnu.org \
--cc=drcxd@sina.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).