From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?G=C3=B6ktu=C4=9F?= Kayaalp Newsgroups: gmane.emacs.bugs Subject: bug#28570: 27.0.50; [PATCH] Disable unhelpful default Extra: header in vc-dir Date: Sun, 08 Oct 2017 11:03:20 +0300 Message-ID: References: <96981f7d-f3ca-b7bb-89aa-10c211249603@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1507449859 1405 195.159.176.226 (8 Oct 2017 08:04:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 8 Oct 2017 08:04:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 28570@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 08 10:04:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e16ZA-00077a-QV for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Oct 2017 10:04:04 +0200 Original-Received: from localhost ([::1]:52839 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e16ZI-0001Sh-5m for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Oct 2017 04:04:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e16ZC-0001SY-69 for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2017 04:04:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e16Z8-0001gg-UC for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2017 04:04:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46780) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e16Z8-0001gS-Od for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2017 04:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e16Z8-0000N6-BB for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2017 04:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?G=C3=B6ktu=C4=9F?= Kayaalp Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Oct 2017 08:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28570 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28570-submit@debbugs.gnu.org id=B28570.15074498071384 (code B ref 28570); Sun, 08 Oct 2017 08:04:02 +0000 Original-Received: (at 28570) by debbugs.gnu.org; 8 Oct 2017 08:03:27 +0000 Original-Received: from localhost ([127.0.0.1]:55461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e16YZ-0000MF-Dc for submit@debbugs.gnu.org; Sun, 08 Oct 2017 04:03:27 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:42110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e16YX-0000M7-C0 for 28570@debbugs.gnu.org; Sun, 08 Oct 2017 04:03:26 -0400 X-Originating-IP: 188.3.108.78 Original-Received: from alpha.alpha (unknown [188.3.108.78]) (Authenticated sender: self@gkayaalp.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 0EE54C5A55; Sun, 8 Oct 2017 10:03:22 +0200 (CEST) In-Reply-To: <96981f7d-f3ca-b7bb-89aa-10c211249603@yandex.ru> (Dmitry Gutov's message of "Mon, 25 Sep 2017 03:24:15 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138069 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2017-09-25 03:24 +03, Dmitry Gutov wrote: > On 9/23/17 6:39 PM, G=C3=B6ktu=C4=9F Kayaalp wrote: >> >> The function =E2=80=98vc-default-dir-extra-headers=E2=80=99 is implement= ed as a stub >> function that prints in the vc-dir buffer a rather annoying and >> unhelpful message advicing that the implementer of a VC backend should >> create some backend specific headers and that doing this is easy. >> vc-rcs doesn't implement any (and I doubt it needs), and thus whenever I >> use vc-dir on an RCS repository, this message is shown. Attached is a >> patch that disables this behaviour by making the said function return >> nil instead (the function as it is includes a comment that says to do so >> before the =E2=80=98release=E2=80=99). > > Instead of changing the default, how about we create a RCS-specific > implementation that does nothing? Because it doesn't need to. > Hi, please find attached the patch I promised some time ago. Sorry for the latency. --=20 =C4=B0. G=C3=B6ktu=C4=9F Kayaalp 024C 30DD 597D 142B 49AC 40EB 465C D949 B101 2427 --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: The patch diff --git a/lisp/vc/vc-rcs.el b/lisp/vc/vc-rcs.el index 9dffc144c6..0a10449763 100644 --- a/lisp/vc/vc-rcs.el +++ b/lisp/vc/vc-rcs.el @@ -177,6 +177,8 @@ vc-rcs-dir-status-files (push (list frel state) result)))) (funcall update-function result))) +(defun vc-rcs-dir-extra-headers (&rest ignore)) + (defun vc-rcs-working-revision (file) "RCS-specific version of `vc-working-revision'." (or (and vc-consult-headers --=-=-=--