unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: David Koppelman <koppel@ece.lsu.edu>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: lee <lee@yun.yagibdah.de>, Lars Ingebrigtsen <larsi@gnus.org>,
	17021@debbugs.gnu.org
Subject: bug#17021: 24.3.50; extension to hi-lock.el
Date: Thu, 13 Aug 2020 16:46:14 -0500	[thread overview]
Message-ID: <yg57du2usm1.fsf@cyc.ece.lsu.edu> (raw)
In-Reply-To: <CADwFkmn4_j+oL=_UbbLHKvDW6Eh8v+cVHg5+_F7o5PgLq1zF4w@mail.gmail.com> (Stefan Kangas's message of "Thu, 13 Aug 2020 12:50:20 -0700")

I've looked at the patch, but haven't tried to apply it to the current
hi-lock. There are two things that need to be addressed before I would
be happy with it landing.

First, this patch should not include the code for highlighting global
variables, function-like text, and constants. (Perhaps this code was
included by accident.) Those situations are best handled by the
font-lock modes for specific languages.

Second, I don't feel comfortable reading a pattern file path from
within the file being visited. Instead, some kind of identifier could
be read from the file, such as xyz-report-patterns. That identifier
would then be used to locate patterns from a file in some default
location, such as ~/.emacs.d/hi-lock-patterns, or it could be used to
construct a file name (but not a path) that would be expected in some
directory, such as ~/.emacs.d/hi-lock-patterns/.

David Koppelman





  reply	other threads:[~2020-08-13 21:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-17  4:18 bug#17021: 24.3.50; extension to hi-lock.el lee
2014-03-17  8:21 ` lee
2014-03-17 10:53   ` lee
2014-03-24  4:54 ` bug#17021: updated patch lee
2020-08-13 10:32 ` bug#17021: 24.3.50; extension to hi-lock.el Lars Ingebrigtsen
2020-08-13 18:43   ` David Koppelman
2020-08-13 19:50     ` Stefan Kangas
2020-08-13 21:46       ` David Koppelman [this message]
2020-08-16 17:49         ` hw
2020-08-17  0:32           ` Juri Linkov
2020-09-14 15:07             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yg57du2usm1.fsf@cyc.ece.lsu.edu \
    --to=koppel@ece.lsu.edu \
    --cc=17021@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=lee@yun.yagibdah.de \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).