From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "David M. Koppelman" Newsgroups: gmane.emacs.bugs Subject: bug#51101: 29.0.50; read-char-from-minibuffer accepts Enter even when not a choice. Date: Fri, 08 Oct 2021 15:19:48 -0500 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15736"; mail-complaints-to="usenet@ciao.gmane.io" To: 51101@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 08 22:20:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYwLl-0003xM-F6 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Oct 2021 22:20:13 +0200 Original-Received: from localhost ([::1]:34254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYwLk-0007gl-1U for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Oct 2021 16:20:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYwLa-0007gc-Jv for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 16:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40421) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYwLa-0002UV-CF for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 16:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mYwLa-0002Wk-15 for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 16:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "David M. Koppelman" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Oct 2021 20:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51101 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16337244019708 (code B ref -1); Fri, 08 Oct 2021 20:20:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 8 Oct 2021 20:20:01 +0000 Original-Received: from localhost ([127.0.0.1]:51967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYwLY-0002WP-MV for submit@debbugs.gnu.org; Fri, 08 Oct 2021 16:20:01 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:37660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYwLW-0002WI-TD for submit@debbugs.gnu.org; Fri, 08 Oct 2021 16:19:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYwLW-0007gP-Nx for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 16:19:58 -0400 Original-Received: from relaymail001.lsu.edu ([130.39.6.46]:40858 helo=relay.lsu.edu) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYwLT-0002Mr-3m for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 16:19:57 -0400 Original-Received: from cyc.ece.lsu.edu (cyc.ece.lsu.edu [96.125.115.182]) by relay.lsu.edu (Postfix) with ESMTPS id F173C219BD43 for ; Fri, 8 Oct 2021 15:19:48 -0500 (CDT) Received-SPF: pass client-ip=130.39.6.46; envelope-from=eekopp@lsu.edu; helo=relay.lsu.edu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216735 Archived-At: Execute: (read-char-from-minibuffer "Answer y or n" '(?y ?n)) and press Enter. The form returns Enter (13) rather than re-prompting for a y or n. This causes a dataloss threat due to read-char-from-minibuffer being called through ask-user-about-supersession-threat. Even if the read-char-from-minibuffer bug is quickly fixed, I'd sleep better if the following patch were applied to userlock.el: @@ -194,7 +194,9 @@ ask-user-about-supersession-threat (list "File reverted" filename))) ((eq answer ?n) (signal 'file-supersession - (list "File changed on disk" filename))))) + (list "File changed on disk" filename))) + ((eq answer ?y)) + (t (setq answer nil)))) (message "File on disk now will become a backup file if you save these changes.") (setq buffer-backed-up nil)))) In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.17.4) of 2021-10-08 built on dmk-laptop-21 Repository revision: e73c9ac4ed4ce0a4b423dae6acbfb384c1afbce0 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101002 System Description: Fedora Linux 35 (KDE Plasma Prerelease) Configured using: 'configure 'CFLAGS=-O3 -march=native' --without-pop --with-native-compilation' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LC_COLLATE: C value of $LC_TIME: C value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search seq gv byte-opt bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date subr-x cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 68625 10824) (symbols 48 6630 0) (strings 32 19929 1554) (string-bytes 1 675055) (vectors 16 13948) (vector-slots 8 286810 18217) (floats 8 24 38) (intervals 56 232 0) (buffers 992 11))