unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Makoto Fujiwara <makoto@ki.nu>
To: 6490@debbugs.gnu.org
Cc: Tetsurou Okazaki <okazaki@be.to>
Subject: bug#6490: 24.0.50; src/lread.c: old style backquote bug?
Date: Thu, 01 Jul 2010 13:14:48 +0900	[thread overview]
Message-ID: <yfm4ogj25zb.wl%makoto@ki.nu> (raw)
In-Reply-To: <jwv8w66btf6.fsf-monnier+emacs@gnu.org>

first of all, I got the very much similar problem with
hnf-mode (2.5)
  http://nijino.homelinux.net/hnf-mode/

And the patch by Okazaki San fixed my problem. Thank you.

  I have looked at the patch, and minimized the changes in
diff wise.  It is logically exactly the same as the first
patch.

  This second patch also fixes my problem. If you look at this
patch, the changes almost nothing to the human being (just not
modifying char c).

diff --git a/src/lread.c b/src/lread.c
index c73f7f3..de01387 100644
--- a/src/lread.c
+++ b/src/lread.c
@@ -2693,7 +2693,11 @@ read1 (readcharfun, pch, first_in_list)
 	 old-style.  For Emacs-25, we should completely remove this
 	 first_in_list exception (old-style can still be obtained via
 	 "(\`" anyway).  */
-      if (first_in_list && (c = READCHAR, UNREAD (c), c == ' '))
+      {
+	 int next_char = READCHAR;
+	 UNREAD (next_char);
+
+      if (first_in_list && next_char == ' ')
 	{
 	  Vold_style_backquotes = Qt;
 	  goto default_label;
@@ -2708,6 +2712,7 @@ read1 (readcharfun, pch, first_in_list)
 
 	  return Fcons (Qbackquote, Fcons (value, Qnil));
 	}
+      }
 
     case ',':
       if (new_backquote_flag)

---
Makoto Fujiwara, 
Chiba, Japan, Narita Airport and Disneyland prefecture.





  reply	other threads:[~2010-07-01  4:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-22  9:16 bug#6490: 24.0.50; src/lread.c: old style backquote bug? Tetsurou Okazaki
2010-06-22 22:23 ` Stefan Monnier
2010-07-01  4:14   ` Makoto Fujiwara [this message]
2010-07-01  5:41   ` Tetsurou Okazaki
2010-07-04 21:50     ` Stefan Monnier
2010-07-04 23:58       ` Makoto Fujiwara
2011-09-21 20:54         ` Lars Magne Ingebrigtsen
2011-09-22  1:43           ` Stefan Monnier
2010-07-05  1:51     ` Makoto Fujiwara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yfm4ogj25zb.wl%makoto@ki.nu \
    --to=makoto@ki.nu \
    --cc=6490@debbugs.gnu.org \
    --cc=okazaki@be.to \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).