From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: 7178@debbugs.gnu.org
Subject: bug#7178: 24.0.50; Emacs 24 doesn't build on Solaris 10
Date: Fri, 08 Oct 2010 22:04:28 +0200 [thread overview]
Message-ID: <yddsk0gzc1f.fsf@manam.CeBiTec.Uni-Bielefeld.DE> (raw)
When I tried to build Emacs bazaar trunk on Solaris 10 to check if
bug#7163 still occurs on trunk, I ran into two issues:
* lisp/Makefile.in (compile-clean) uses $() which the Solaris 10 /bin/sh
doesn't understand. This can easily be avoided by using `` instead.
* src/sysdep.c doesn't compile:
"/usr/include/term.h", line 1034: syntax error before or at: bool
<term.h> uses bool without providing bool. <stdbool.h> cannot be
included since it only works in C99 mode. The documented solution
(e.g. on the curs_terminfo(3CURSES) manpage) is to include <curses.h>
before term.h. The patch below hardcodes this, but this is most
likely not the appropriate solution. Some kind of autoconf magic is
probably needed to check if <term.h> can be compiled on its own.
Rainer
2010-10-08 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
src:
* sysdep.c [HAVE_TERM_H]: Include <curses.h> before <term.h>.
lisp:
* Makefile.in (compile-clean): Use `` instead of $().
=== modified file 'lisp/Makefile.in'
--- lisp/Makefile.in 2010-09-08 14:42:54 +0000
+++ lisp/Makefile.in 2010-09-08 20:49:05 +0000
@@ -249,7 +249,7 @@
compile-clean:
@cd $(lisp); $(setwins); \
elcs=`echo "$$wins " | sed -e 's|/\./|/|g' -e 's|/\. | |g' -e 's| |/*.elc |g'`; \
- for el in $$(echo $$elcs | sed -e 's/\.elc/\.el/g'); do \
+ for el in `echo $$elcs | sed -e 's/\.elc/\.el/g'`; do \
if test -f "$$el" -o \! -f "$${el}c"; then :; else \
echo rm "$${el}c"; \
rm "$${el}c"; \
=== modified file 'src/sysdep.c'
--- src/sysdep.c 2010-08-22 15:14:37 +0000
+++ src/sysdep.c 2010-09-08 20:34:07 +0000
@@ -97,6 +97,7 @@
/* Include this last. If it is ncurses header file, it adds a lot of
defines that interfere with stuff in other headers. Someone responsible
for ncurses messed up bigtime. See bug#6812. */
+#include <curses.h>
#include <term.h>
#endif
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next reply other threads:[~2010-10-08 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 20:04 Rainer Orth [this message]
2010-10-10 14:07 ` bug#7178: 24.0.50; Emacs 24 doesn't build on Solaris 10 Dan Nicolaescu
2010-12-06 17:07 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddsk0gzc1f.fsf@manam.CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=7178@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).