unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#40001: tex-start-options-string not updated in texinfo.el
@ 2020-03-09 17:26 Ernest N. Mamikonyan
  2020-03-13 13:53 ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Ernest N. Mamikonyan @ 2020-03-09 17:26 UTC (permalink / raw)
  To: 40001

Hi,

It seems that 'tex-start-options-string' was not updated to
'tex-start-options' in texinfo.el after the change in version 22.

diff --git a/lisp/textmodes/texinfo.el b/lisp/textmodes/texinfo.el
index 438cb7798a..3898a3ba04 100644
--- a/lisp/textmodes/texinfo.el
+++ b/lisp/textmodes/texinfo.el
@@ -1002,9 +1002,9 @@ texinfo-tex-buffer
   (interactive)
   (require 'tex-mode)
   (let ((tex-command texinfo-texi2dvi-command)
-	;; Disable tex-start-options-string.  texi2dvi would not
-	;; understand anything specified here.
-	(tex-start-options-string ""))
+	;; Disable tex-start-options.  texi2dvi would not understand
+	;; anything specified here.
+	(tex-start-options ""))
     (tex-buffer)))
 
 (defun texinfo-texindex ()


Best,

--
Ernie





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#40001: tex-start-options-string not updated in texinfo.el
  2020-03-09 17:26 bug#40001: tex-start-options-string not updated in texinfo.el Ernest N. Mamikonyan
@ 2020-03-13 13:53 ` Eli Zaretskii
  2020-03-13 14:37   ` Ernest N. Mamikonyan
  2020-03-30 19:25   ` Ernest N. Mamikonyan
  0 siblings, 2 replies; 6+ messages in thread
From: Eli Zaretskii @ 2020-03-13 13:53 UTC (permalink / raw)
  To: Ernest N. Mamikonyan; +Cc: 40001

> From: "Ernest N. Mamikonyan" <Ernest.Mamikonyan@sig.com>
> Date: Mon, 09 Mar 2020 13:26:44 -0400
> 
> It seems that 'tex-start-options-string' was not updated to
> 'tex-start-options' in texinfo.el after the change in version 22.
> 
> diff --git a/lisp/textmodes/texinfo.el b/lisp/textmodes/texinfo.el
> index 438cb7798a..3898a3ba04 100644
> --- a/lisp/textmodes/texinfo.el
> +++ b/lisp/textmodes/texinfo.el
> @@ -1002,9 +1002,9 @@ texinfo-tex-buffer
>    (interactive)
>    (require 'tex-mode)
>    (let ((tex-command texinfo-texi2dvi-command)
> -	;; Disable tex-start-options-string.  texi2dvi would not
> -	;; understand anything specified here.
> -	(tex-start-options-string ""))
> +	;; Disable tex-start-options.  texi2dvi would not understand
> +	;; anything specified here.
> +	(tex-start-options ""))
>      (tex-buffer)))

Should we also bind tex-start-commands to some value (an empty
string)?  If not, why not?

Thanks.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#40001: tex-start-options-string not updated in texinfo.el
  2020-03-13 13:53 ` Eli Zaretskii
@ 2020-03-13 14:37   ` Ernest N. Mamikonyan
  2020-03-30 19:25   ` Ernest N. Mamikonyan
  1 sibling, 0 replies; 6+ messages in thread
From: Ernest N. Mamikonyan @ 2020-03-13 14:37 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 40001

On Fri, Mar 13 2020, Eli Zaretskii wrote:

>> From: "Ernest N. Mamikonyan" <Ernest.Mamikonyan@sig.com>
>> Date: Mon, 09 Mar 2020 13:26:44 -0400
>> 
>> It seems that 'tex-start-options-string' was not updated to
>> 'tex-start-options' in texinfo.el after the change in version 22.
>> 
>> diff --git a/lisp/textmodes/texinfo.el b/lisp/textmodes/texinfo.el
>> index 438cb7798a..3898a3ba04 100644
>> --- a/lisp/textmodes/texinfo.el
>> +++ b/lisp/textmodes/texinfo.el
>> @@ -1002,9 +1002,9 @@ texinfo-tex-buffer
>>    (interactive)
>>    (require 'tex-mode)
>>    (let ((tex-command texinfo-texi2dvi-command)
>> -	;; Disable tex-start-options-string.  texi2dvi would not
>> -	;; understand anything specified here.
>> -	(tex-start-options-string ""))
>> +	;; Disable tex-start-options.  texi2dvi would not understand
>> +	;; anything specified here.
>> +	(tex-start-options ""))
>>      (tex-buffer)))
>
> Should we also bind tex-start-commands to some value (an empty
> string)?  If not, why not?

Yes, you're right. Since texi2dvi doesn't take initial commands like
TeX, why not get rid of tex-start-commands but allow the user to supply
command-line options:

diff --git a/lisp/textmodes/texinfo.el b/lisp/textmodes/texinfo.el
index 438cb7798a..a687a27e36 100644
--- a/lisp/textmodes/texinfo.el
+++ b/lisp/textmodes/texinfo.el
@@ -958,6 +958,11 @@ texinfo-texi2dvi-command
   :type 'string
   :group 'texinfo)
 
+(defcustom texinfo-texi2dvi-options ""
+  "Command line options for `texinfo-texi2dvi-command'."
+  :type 'string
+  :group 'texinfo)
+
 (defcustom texinfo-tex-command "tex"
   "Command used by `texinfo-tex-region' to run TeX on a region."
   :type 'string
@@ -1002,9 +1007,10 @@ texinfo-tex-buffer
   (interactive)
   (require 'tex-mode)
   (let ((tex-command texinfo-texi2dvi-command)
-	;; Disable tex-start-options-string.  texi2dvi would not
-	;; understand anything specified here.
-	(tex-start-options-string ""))
+	(tex-start-options texinfo-texi2dvi-options)
+	;; Disable tex-start-commands.  texi2dvi would not understand
+	;; anything specified here.
+        (tex-start-commands ""))
     (tex-buffer)))
 
 (defun texinfo-texindex ()


-- 
Ernie





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#40001: tex-start-options-string not updated in texinfo.el
  2020-03-13 13:53 ` Eli Zaretskii
  2020-03-13 14:37   ` Ernest N. Mamikonyan
@ 2020-03-30 19:25   ` Ernest N. Mamikonyan
  2020-03-31 14:10     ` Eli Zaretskii
  1 sibling, 1 reply; 6+ messages in thread
From: Ernest N. Mamikonyan @ 2020-03-30 19:25 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 40001

On Fri, Mar 13 2020, Eli Zaretskii wrote:

> Should we also bind tex-start-commands to some value (an empty
> string)? If not, why not?

Sorry, not sure if you had a chance to look at the previous patch, based
on your suggestion. Do you agree with the approach?

Best,

-- 
Ernie





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#40001: tex-start-options-string not updated in texinfo.el
  2020-03-30 19:25   ` Ernest N. Mamikonyan
@ 2020-03-31 14:10     ` Eli Zaretskii
  2020-04-03 12:14       ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2020-03-31 14:10 UTC (permalink / raw)
  To: Ernest N. Mamikonyan; +Cc: 40001

> From: "Ernest N. Mamikonyan" <Ernest.Mamikonyan@sig.com>
> Cc: <40001@debbugs.gnu.org>
> Date: Mon, 30 Mar 2020 15:25:15 -0400
> 
> On Fri, Mar 13 2020, Eli Zaretskii wrote:
> 
> > Should we also bind tex-start-commands to some value (an empty
> > string)? If not, why not?
> 
> Sorry, not sure if you had a chance to look at the previous patch, based
> on your suggestion. Do you agree with the approach?

Yes, I will handle this soon.  Thanks for the reminder.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#40001: tex-start-options-string not updated in texinfo.el
  2020-03-31 14:10     ` Eli Zaretskii
@ 2020-04-03 12:14       ` Eli Zaretskii
  0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2020-04-03 12:14 UTC (permalink / raw)
  To: Ernest.Mamikonyan; +Cc: 40001-done

> Date: Tue, 31 Mar 2020 17:10:35 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 40001@debbugs.gnu.org
> 
> > From: "Ernest N. Mamikonyan" <Ernest.Mamikonyan@sig.com>
> > Cc: <40001@debbugs.gnu.org>
> > Date: Mon, 30 Mar 2020 15:25:15 -0400
> > 
> > On Fri, Mar 13 2020, Eli Zaretskii wrote:
> > 
> > > Should we also bind tex-start-commands to some value (an empty
> > > string)? If not, why not?
> > 
> > Sorry, not sure if you had a chance to look at the previous patch, based
> > on your suggestion. Do you agree with the approach?
> 
> Yes, I will handle this soon.  Thanks for the reminder.

Thanks, pushed to the master branch.





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-04-03 12:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-09 17:26 bug#40001: tex-start-options-string not updated in texinfo.el Ernest N. Mamikonyan
2020-03-13 13:53 ` Eli Zaretskii
2020-03-13 14:37   ` Ernest N. Mamikonyan
2020-03-30 19:25   ` Ernest N. Mamikonyan
2020-03-31 14:10     ` Eli Zaretskii
2020-04-03 12:14       ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).