* bug#2333: 23.0.90; rmail: rmail-summary-by-topic is not reliable @ 2009-02-14 23:25 ` Xavier Maillard [not found] ` <handler.2333.B.123465396613879.ack@emacsbugs.donarmstrong.com> ` (2 more replies) 0 siblings, 3 replies; 4+ messages in thread From: Xavier Maillard @ 2009-02-14 23:25 UTC (permalink / raw) To: emacs-pretest-bug Here is an excerpt of my rmail summary buffer. The point is on message number 7840. 7838D 3-Feb nathanfritz@gmail.com [95] { summit } [Summit] Prepaid cellphones 7839D 3-Feb remko@el-tramo.be [95] { summit } Re: [Summit] Prepaid cellphones 7840D 3-Feb admin@flosoft.biz [114] { summit } Re: [Summit] Prepaid cellphones 7844D 3-Feb remko@el-tramo.be [92] { summit } Re: [Summit] Prepaid cellphones Doing C-M-t RET -i.e. choosing default subject as the topic returns: No previous message. More generally, rmail-summary-by-topic is rather unreliable since less than 50% of the time it will return correct results. I do not see how to debug that. I will try with edebug-defun on every part of the rmail-summary-by-topic function. In GNU Emacs 23.0.90.2 (i686-pc-linux-gnu, GTK+ Version 2.12.12) of 2009-02-14 on zogzog Windowing system distributor `The X.Org Foundation', version 11.0.10402000 configured using `configure '--without-xft'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: en_US.UTF-8 value of $LC_CTYPE: fr_FR.UTF-8 value of $LC_MESSAGES: en_US.UTF-8 value of $LC_MONETARY: fr_FR.UTF-8 value of $LC_NUMERIC: en_US.UTF-8 value of $LC_TIME: en_US.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: RMAIL Summary Minor modes in effect: rcirc-track-minor-mode: t eev-mode: t jabber-activity-mode: t auto-insert-mode: t global-hi-lock-mode: t hi-lock-mode: t show-paren-mode: t global-auto-revert-mode: t display-time-mode: t shell-dirtrack-mode: t recentf-mode: t icomplete-mode: t desktop-save-mode: t auto-image-file-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t transient-mark-mode: t abbrev-mode: t Recent input: <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> C-SPC <down> <left> <left> C-w C-e C-x C-e <left> <left> <left> <left> <left> <backspace> , C-e C-x C-e C-x C-b C-x o h C-x 1 M-x e m a c s - b u <backspace> <backspace> r e p o <backspace> <backspace> <backspace> <backspace> b u g <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> b u g <tab> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> e m a c s - r e p o <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> r e p o r <tab> <return> r m a i l : SPC r m a i l - s C-h f r m a i l - s s u m <backspace> <backspace> <backspace> y u <backspace> <backspace> u m m a r y - b y - t o p <tab> <backspace> <backspace> <backspace> <backspace> <backspace> r e g <tab> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> t o p <tab> <return> u m m a r y - b y - t o p i c SPC i s SPC n o t SPC r e l i a l <backspace> b l e <return> <up> q M-x <up> < return> Recent messages: Commands: m, u, t, RET, g, k, S, D, Q; q to quit; h for help Mark set [3 times] "cron: cd ~/howm && ~/usr/src/bzr-repo/trunk/bzr add" "cron: cd ~/howm && ~/usr/src/bzr-repo/trunk/bzr\\|add" Updating buffer list... Mark set Updating buffer list...done Commands: m, u, t, RET, g, k, S, D, Q; q to quit; h for help Computing summary lines...done Type "q" to restore this window. Xavier -- http://www.gnu.org http://www.april.org http://www.lolica.org ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <handler.2333.B.123465396613879.ack@emacsbugs.donarmstrong.com>]
* bug#2333: Acknowledgement (23.0.90; rmail: rmail-summary-by-topic is not reliable) [not found] ` <handler.2333.B.123465396613879.ack@emacsbugs.donarmstrong.com> @ 2009-02-16 7:24 ` Xavier Maillard 0 siblings, 0 replies; 4+ messages in thread From: Xavier Maillard @ 2009-02-16 7:24 UTC (permalink / raw) To: 2333 reassign 2333 rmail Xavier -- http://www.gnu.org http://www.april.org http://www.lolica.org ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#2333: 23.0.90; rmail: rmail-summary-by-topic is not reliable 2009-02-14 23:25 ` bug#2333: 23.0.90; rmail: rmail-summary-by-topic is not reliable Xavier Maillard [not found] ` <handler.2333.B.123465396613879.ack@emacsbugs.donarmstrong.com> @ 2009-02-18 21:56 ` Glenn Morris 2009-02-19 3:35 ` bug#2333: marked as done (23.0.90; rmail: rmail-summary-by-topic is not reliable) Emacs bug Tracking System 2 siblings, 0 replies; 4+ messages in thread From: Glenn Morris @ 2009-02-18 21:56 UTC (permalink / raw) To: Xavier Maillard; +Cc: 2333 Xavier Maillard wrote: > 7840D 3-Feb admin@flosoft.biz [114] { summit } Re: [Summit] Prepaid cellphones [...] > Doing C-M-t RET -i.e. choosing default subject as the topic returns: > No previous message. More generally, rmail-summary-by-topic is > rather unreliable since less than 50% of the time it will return > correct results. One problem is that rmail-summary-by-topic does not regexp-quote the default expression to search for. This leads to the confusing result that you can fail to find the current message, if the subject happens to contain regexp special characters, eg "[ ]" in your example. The patch for that is trivial, and seems like the right thing to do. The "no previous message" message indicates that more care needs to be taken somewhere when there are no matches. *** rmailsum.el 15 Feb 2009 02:52:16 -0000 1.170 --- rmailsum.el 18 Feb 2009 21:55:17 -0000 *************** *** 155,161 **** look in the whole message. SUBJECT is a string of regexps separated by commas." (interactive ! (let* ((subject (rmail-simplified-subject)) (prompt (concat "Topics to summarize by (regexp" (if subject ", default current subject" "") "): "))) --- 155,161 ---- look in the whole message. SUBJECT is a string of regexps separated by commas." (interactive ! (let* ((subject (regexp-quote (rmail-simplified-subject))) (prompt (concat "Topics to summarize by (regexp" (if subject ", default current subject" "") "): "))) ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#2333: marked as done (23.0.90; rmail: rmail-summary-by-topic is not reliable) 2009-02-14 23:25 ` bug#2333: 23.0.90; rmail: rmail-summary-by-topic is not reliable Xavier Maillard [not found] ` <handler.2333.B.123465396613879.ack@emacsbugs.donarmstrong.com> 2009-02-18 21:56 ` bug#2333: 23.0.90; rmail: rmail-summary-by-topic is not reliable Glenn Morris @ 2009-02-19 3:35 ` Emacs bug Tracking System 2 siblings, 0 replies; 4+ messages in thread From: Emacs bug Tracking System @ 2009-02-19 3:35 UTC (permalink / raw) To: Glenn Morris [-- Attachment #1: Type: text/plain, Size: 910 bytes --] Your message dated Wed, 18 Feb 2009 22:30:18 -0500 with message-id <dcd4dfm7cl.fsf@fencepost.gnu.org> and subject line Re: bug#2333: 23.0.90; rmail: rmail-summary-by-topic is not reliable has caused the Emacs bug report #2333, regarding 23.0.90; rmail: rmail-summary-by-topic is not reliable to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) -- 2333: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2333 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 7076 bytes --] From: Xavier Maillard <xma@gnu.org> To: emacs-pretest-bug@gnu.org Subject: 23.0.90; rmail: rmail-summary-by-topic is not reliable Date: Sun, 15 Feb 2009 00:25:03 +0100 Message-ID: <200902142325.n1ENP3s3027009@zogzog.maillard.mobi> Here is an excerpt of my rmail summary buffer. The point is on message number 7840. 7838D 3-Feb nathanfritz@gmail.com [95] { summit } [Summit] Prepaid cellphones 7839D 3-Feb remko@el-tramo.be [95] { summit } Re: [Summit] Prepaid cellphones 7840D 3-Feb admin@flosoft.biz [114] { summit } Re: [Summit] Prepaid cellphones 7844D 3-Feb remko@el-tramo.be [92] { summit } Re: [Summit] Prepaid cellphones Doing C-M-t RET -i.e. choosing default subject as the topic returns: No previous message. More generally, rmail-summary-by-topic is rather unreliable since less than 50% of the time it will return correct results. I do not see how to debug that. I will try with edebug-defun on every part of the rmail-summary-by-topic function. In GNU Emacs 23.0.90.2 (i686-pc-linux-gnu, GTK+ Version 2.12.12) of 2009-02-14 on zogzog Windowing system distributor `The X.Org Foundation', version 11.0.10402000 configured using `configure '--without-xft'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: en_US.UTF-8 value of $LC_CTYPE: fr_FR.UTF-8 value of $LC_MESSAGES: en_US.UTF-8 value of $LC_MONETARY: fr_FR.UTF-8 value of $LC_NUMERIC: en_US.UTF-8 value of $LC_TIME: en_US.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: RMAIL Summary Minor modes in effect: rcirc-track-minor-mode: t eev-mode: t jabber-activity-mode: t auto-insert-mode: t global-hi-lock-mode: t hi-lock-mode: t show-paren-mode: t global-auto-revert-mode: t display-time-mode: t shell-dirtrack-mode: t recentf-mode: t icomplete-mode: t desktop-save-mode: t auto-image-file-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t transient-mark-mode: t abbrev-mode: t Recent input: <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> C-SPC <down> <left> <left> C-w C-e C-x C-e <left> <left> <left> <left> <left> <backspace> , C-e C-x C-e C-x C-b C-x o h C-x 1 M-x e m a c s - b u <backspace> <backspace> r e p o <backspace> <backspace> <backspace> <backspace> b u g <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> b u g <tab> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> e m a c s - r e p o <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> r e p o r <tab> <return> r m a i l : SPC r m a i l - s C-h f r m a i l - s s u m <backspace> <backspace> <backspace> y u <backspace> <backspace> u m m a r y - b y - t o p <tab> <backspace> <backspace> <backspace> <backspace> <backspace> r e g <tab> <backspace> <backspace> <backspace> <backspace> <backspace> <backspace> t o p <tab> <return> u m m a r y - b y - t o p i c SPC i s SPC n o t SPC r e l i a l <backspace> b l e <return> <up> q M-x <up> < return> Recent messages: Commands: m, u, t, RET, g, k, S, D, Q; q to quit; h for help Mark set [3 times] "cron: cd ~/howm && ~/usr/src/bzr-repo/trunk/bzr add" "cron: cd ~/howm && ~/usr/src/bzr-repo/trunk/bzr\\|add" Updating buffer list... Mark set Updating buffer list...done Commands: m, u, t, RET, g, k, S, D, Q; q to quit; h for help Computing summary lines...done Type "q" to restore this window. Xavier -- http://www.gnu.org http://www.april.org http://www.lolica.org [-- Attachment #3: Type: message/rfc822, Size: 1700 bytes --] From: Glenn Morris <rgm@gnu.org> To: 2333-done@emacsbugs.donarmstrong.com Subject: Re: bug#2333: 23.0.90; rmail: rmail-summary-by-topic is not reliable Date: Wed, 18 Feb 2009 22:30:18 -0500 Message-ID: <dcd4dfm7cl.fsf@fencepost.gnu.org> 2009-02-19 Glenn Morris <rgm@gnu.org> * mail/rmailsum.el (rmail-summary-by-topic): Doc fix. Regexp-quote default argument taken from current subject. (rmail-new-summary-1): Error if empty summary. (Bug#2333) ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-02-19 3:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <dcd4dfm7cl.fsf@fencepost.gnu.org>
2009-02-14 23:25 ` bug#2333: 23.0.90; rmail: rmail-summary-by-topic is not reliable Xavier Maillard
[not found] ` <handler.2333.B.123465396613879.ack@emacsbugs.donarmstrong.com>
2009-02-16 7:24 ` bug#2333: Acknowledgement (23.0.90; rmail: rmail-summary-by-topic is not reliable) Xavier Maillard
2009-02-18 21:56 ` bug#2333: 23.0.90; rmail: rmail-summary-by-topic is not reliable Glenn Morris
2009-02-19 3:35 ` bug#2333: marked as done (23.0.90; rmail: rmail-summary-by-topic is not reliable) Emacs bug Tracking System
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).