From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Welsh Duggan Newsgroups: gmane.emacs.bugs Subject: bug#47244: 28.0.50; SIGSEGV in long-runnning Emacs Date: Thu, 08 Apr 2021 13:51:24 -0400 Message-ID: References: <87im5ofp3z.fsf@md5i.com> <79cfe67d-3a2c-952d-7c51-20e8a4859380@gmx.at> <87czv6q1f8.fsf@md5i.com> <233daa4b-ca64-955f-2612-49a0503b1938@gmx.at> <8735w2p8oc.fsf@md5i.com> <5181da75-e80d-22e0-bdcb-a0ffdc1bac6a@gmx.at> <5c4e5857-6a76-b8e8-204b-b4a855e95a16@gmx.at> <8f4516d5-1080-71bb-7da7-acf7832d5529@gmx.at> <87r1jlvnrc.fsf@md5i.com> <871rbkn6op.fsf@md5i.com> <83pmz493ag.fsf@gnu.org> <83im4w8yam.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38104"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "mwd@md5i.com" , "schwab@linux-m68k.org" , "47244@debbugs.gnu.org" <47244@debbugs.gnu.org> To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 08 19:52:34 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUYpV-0009jy-8u for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Apr 2021 19:52:33 +0200 Original-Received: from localhost ([::1]:36494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUYpU-0005uM-2u for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Apr 2021 13:52:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUYp0-0005lC-IF for bug-gnu-emacs@gnu.org; Thu, 08 Apr 2021 13:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36729) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lUYp0-0004vN-8c for bug-gnu-emacs@gnu.org; Thu, 08 Apr 2021 13:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lUYp0-0003ph-7g for bug-gnu-emacs@gnu.org; Thu, 08 Apr 2021 13:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Welsh Duggan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Apr 2021 17:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47244 X-GNU-PR-Package: emacs Original-Received: via spool by 47244-submit@debbugs.gnu.org id=B47244.161790430614686 (code B ref 47244); Thu, 08 Apr 2021 17:52:02 +0000 Original-Received: (at 47244) by debbugs.gnu.org; 8 Apr 2021 17:51:46 +0000 Original-Received: from localhost ([127.0.0.1]:48269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUYok-0003of-1k for submit@debbugs.gnu.org; Thu, 08 Apr 2021 13:51:46 -0400 Original-Received: from veto.sei.cmu.edu ([147.72.252.17]:54704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUYoX-0003me-8X for 47244@debbugs.gnu.org; Thu, 08 Apr 2021 13:51:33 -0400 Original-Received: from delp.sei.cmu.edu (delp.sei.cmu.edu [10.64.21.31]) by veto.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id 138HpOqp021268; Thu, 8 Apr 2021 13:51:25 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 veto.sei.cmu.edu 138HpOqp021268 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cert.org; s=yc2bmwvrj62m; t=1617904285; bh=Q5dSGoONN4sYaW9lzdJ9l97aR88HuWg3M84b8fLotQk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=j2IewqN6MVxWIkmH3qwc2OfFB/6060ui86vphF2DUZ6FWkPoZN38h1abx2xI7Ya5d tH2Q8RMvUrcmtkdi9vuLqK/AXO7E2SkHpV6Y7K137Dzb/hvZT94kwVbSmF85W1OBZp T+mKJg6vl2rPAngOaKHig0MS7WAKDIMo9bTNk2Dw= Original-Received: from lx-birch.ad.sei.cmu.edu (lx-birch.ad.sei.cmu.edu [10.64.53.120]) by delp.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id 138HpO1n021346; Thu, 8 Apr 2021 13:51:24 -0400 Original-Received: from lx-birch.ad.sei.cmu.edu (localhost [127.0.0.1]) by lx-birch.ad.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id 138HpOmj019354; Thu, 8 Apr 2021 13:51:24 -0400 Original-Received: (from mwd@localhost) by lx-birch.ad.sei.cmu.edu (8.14.7/8.14.7) id 138HpOSP019351; Thu, 8 Apr 2021 13:51:24 -0400 X-Authentication-Warning: lx-birch.ad.sei.cmu.edu: mwd set sender to mwd@cert.org using -f In-Reply-To: <83im4w8yam.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 8 Apr 2021 13:46:09 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203749 Archived-At: Eli Zaretskii writes: >> From: Michael Welsh Duggan >> Cc: Michael Welsh Duggan , >> "schwab@linux-m68k.org" >> , >> "47244@debbugs.gnu.org" <47244@debbugs.gnu.org> >> Date: Thu, 08 Apr 2021 13:11:34 -0400 >> >> I hit the breakpoint in quit. It looks like Fnconc uses FOR_EACH_TAIL, >> which uses FOR_EACH_TAIL_INTENAL, which calls maybe_quit. The question >> in my mind now is whether block/unblock_input belongs in window_list or >> in Fnconc. > > IMO, the right solution is not block_input but unwind_protect. Mayhap. I look forward to a patch to try out. (I'm not certain how it should be used, myself.) FWIW, it might be worth looking through all uses of FOR_EACH_TAIL to find places that it is used in loops that do destructive updates, like Fdelete, as it seems icky for C-g to leave one of these operations partially completed. -- Michael Welsh Duggan (mwd@cert.org)