unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Andreas Fuchs <asf@boinkor.net>
Cc: 42761@debbugs.gnu.org
Subject: bug#42761: 28.0.50; [feature/native-comp] allow customizing command line/driver options?
Date: Sat, 08 Aug 2020 19:31:14 +0000	[thread overview]
Message-ID: <xjfzh75aq9p.fsf@sdf.org> (raw)
In-Reply-To: <CAOHxn7zEm1vgtkQh=e+-CjqTdchua_DZM7qj_qUN3bjaRe9+Nw@mail.gmail.com> (Andreas Fuchs's message of "Sat, 8 Aug 2020 15:13:53 -0400")

Andreas Fuchs <asf@boinkor.net> writes:

> That makes sense. Assuming that ~everyone would build the native-comp
> branch with a recent (>=9) gcc release, I cut a branch here that
> implements this (it does pass the driver options, too!):
> https://github.com/antifuchs/emacs/compare/
> allow-setting-driver-options
>
> I think this behavior could be made conditional on the presence of
> the
> correct libgccjit ABI version, by declaring the variable in C code,
> and then everyone on a newer gcc would be able to reap the benefits,
> and everyone else could still use the branch, but only with the
> standard linker flags as before (or passing LIBRARY_PATH if that's
> supported on their platform).
>
>> Another option would be to set our self the LIBRARY_PATH before
> invoking
>> the compiler only in the async process.  Have you already tried
> using
>> `comp-async-env-modifier-form' for this?
>
>
> LIBRARY_PATH does work on GNU binutils: the concern for my nixpkgs
> branch is for usage on Darwin, where that environment variable
> doesn't
> do anything. To get anywhere there, we have to have a way to pass
> command-line arguments... /-:
>
> Besides that though, I think it might be useful for folks who want to
> specify that other linkers should be used (like gold or lld), or
> passing a -specs argument... I don't know if that's supported at all
> yet, but adding this option would be an easy way of finding out how
> unsupported it is (-;

Hi Andreas,

didn't know LIBRARY_PATH works only with binutils.  Agree this sounds
useful.

Regarfing the gcc version: ne option would be to just ifdef the body of
add_driver_options using
LIBGCCJIT_HAVE_gcc_jit_context_add_command_line_option and making clear
that the customize is effective only with GCC>=9.

But I think would be better to raise an error if
comp-native-driver-options is not empty and
gcc_jit_context_add_command_line_option is not available.

I think we should make this clear in the customize doc.

Do you already have copyright paperwork done?

Thanks!

  Andrea

PS I may have missed parts of your patch cause I think is untabifying
all touched files generating a very big diff.

-- 
akrl@sdf.org





  reply	other threads:[~2020-08-08 19:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-08  2:51 bug#42761: 28.0.50; [feature/native-comp] allow customizing command line/driver options? Andreas Fuchs
2020-08-08 18:30 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-08 19:13   ` Andreas Fuchs
2020-08-08 19:31     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2020-08-08 20:29       ` Andreas Fuchs
2020-08-09  7:58         ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-11  2:34           ` Andreas Fuchs
2020-08-13 18:46             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-19 14:37               ` Andreas Fuchs
2020-08-19 15:41                 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-20 14:12                   ` Andreas Fuchs
2020-08-20 16:43                     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-22  4:14                       ` Andreas Fuchs
2020-08-24  8:49                         ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-26 19:07                           ` Andreas Fuchs
2020-08-26 19:56                             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xjfzh75aq9p.fsf@sdf.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=42761@debbugs.gnu.org \
    --cc=akrl@sdf.org \
    --cc=asf@boinkor.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).