From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43532: [feature/native-comp] *.eln file name hashing, algorithm doesn't seem to play nice with NATIVE_FULL_AOT and self-contained, Emacs.app builds for macOS Date: Thu, 15 Oct 2020 10:54:45 +0000 Message-ID: References: Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28125"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43532@debbugs.gnu.org, Jim Myhrberg , Aloxaf Yin To: Andrew Whatson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 15 12:55:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kT0uc-0007ED-G8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Oct 2020 12:55:10 +0200 Original-Received: from localhost ([::1]:59930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kT0ub-0003bu-I3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Oct 2020 06:55:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kT0uU-0003bc-OO for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 06:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42978) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kT0uU-0003ad-Dr for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 06:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kT0uU-0008EP-9r for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 06:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Oct 2020 10:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43532 X-GNU-PR-Package: emacs Original-Received: via spool by 43532-submit@debbugs.gnu.org id=B43532.160275928931616 (code B ref 43532); Thu, 15 Oct 2020 10:55:02 +0000 Original-Received: (at 43532) by debbugs.gnu.org; 15 Oct 2020 10:54:49 +0000 Original-Received: from localhost ([127.0.0.1]:54524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kT0uH-0008Ds-9C for submit@debbugs.gnu.org; Thu, 15 Oct 2020 06:54:49 -0400 Original-Received: from mab.sdf.org ([205.166.94.33]:43448 helo=ma.sdf.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kT0uG-0008Dk-98 for 43532@debbugs.gnu.org; Thu, 15 Oct 2020 06:54:48 -0400 Original-Received: from akrl by ma.sdf.org with local (Exim 4.92) (envelope-from ) id 1kT0uD-0006Qi-Tp; Thu, 15 Oct 2020 10:54:45 +0000 In-Reply-To: (Andrew Whatson's message of "Thu, 15 Oct 2020 19:38:48 +1000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190561 Archived-At: Andrew Whatson writes: > Hi Andrea, > > I added some debug messages to the loading procedure and determined > that the files were ignored because the timestamp check required the > eln to be newer than the source file. This makes sense when running > from the build directory or when the eln's are built with deferred > compilation, but doesn't work for packaging where they're usually > installed with the same timestamp. > > Though the fix is trivial, I wonder whether a timestamp check is > needed at all. If we're already hashing the contents of the source > file, perhaps that's sufficient to detect when things are outdated? Hi Andrew, thanks for investigating! yes you are correct, the system is over-constrained and I believe too the timestamp is not anymore necessary now that we hash the file content to verify the .el -> .eln relation. I've pushed the following. 03dfa83dc3 * Do not check eln timestamp as superseded by source hashing (bug#43532) Let us know if the issue is solved. Thanks! Andrea