From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Thu, 18 Feb 2021 20:32:06 +0000 Message-ID: References: <87wny8xwcc.fsf@gnus.org> <83im9sqk1b.fsf@gnu.org> <83v9drp8va.fsf@gnu.org> <831rdjd95w.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26158"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: eliz@gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca To: 43725@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 18 21:41:05 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCq6j-0006hK-6w for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Feb 2021 21:41:05 +0100 Original-Received: from localhost ([::1]:38170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCq6i-0003GK-5V for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Feb 2021 15:41:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCpyw-0004Nu-4j for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 15:33:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36597) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCpyv-0008MI-Qo for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 15:33:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lCpyv-0002WQ-NO for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 15:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Feb 2021 20:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: Eli Zaretskii , larsi@gnus.org, 43725@debbugs.gnu.org, monnier@iro.umontreal.ca Original-Received: via spool by submit@debbugs.gnu.org id=B.16136803479653 (code B ref -1); Thu, 18 Feb 2021 20:33:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Feb 2021 20:32:27 +0000 Original-Received: from localhost ([127.0.0.1]:48143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCpyM-0002Vd-V6 for submit@debbugs.gnu.org; Thu, 18 Feb 2021 15:32:27 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:50468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCpyL-0002VV-E3 for submit@debbugs.gnu.org; Thu, 18 Feb 2021 15:32:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCpyL-0003uj-2b for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 15:32:25 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:52293) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCpyI-0007uc-HX; Thu, 18 Feb 2021 15:32:24 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 11IKW6wI021863 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Thu, 18 Feb 2021 20:32:07 GMT In-Reply-To: (Andrea Corallo via's message of "Tue, 16 Feb 2021 21:13:07 +0000") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200286 Archived-At: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Addressing some easy part of the review to close the day. > > Eli Zaretskii writes: > > [...] >> Several comparisons like this one: >> >> + if (val !=3D (long) val) >> >> are IMO better written as >> >> if (val > LONG_MAX || val < LONG_MIN) > > Fixed by 72e4a22391 I noticed that with the suggested fix applied in configurations where 'val' can't exceed a long on the positive side GCC (trunk from some time ago) is complaining emitting the following warning: comp.c:1174:22: warning: logical =E2=80=98or=E2=80=99 of collectively exhau= stive tests is always true [-Wlogical-op] 1174 | if (val > LONG_MAX || val < LONG_MIN) | ^~ Not sure what's the best way to silence it or if we want to revert to the previous formulation. Andrea