From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#54698: non-recursive GC marking [PATCH] Date: Mon, 04 Apr 2022 14:32:51 +0000 Message-ID: References: <5A577100-75CE-4C9E-A7DA-02B917662AF5@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33321"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 54698@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 04 16:34:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbNmX-0008Mk-3k for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Apr 2022 16:34:13 +0200 Original-Received: from localhost ([::1]:58650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbNmV-00048E-R7 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Apr 2022 10:34:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55542) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbNmM-00046u-IW for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2022 10:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58705) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbNmM-0005ur-9t for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2022 10:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nbNmL-0000Bj-VR for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2022 10:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Apr 2022 14:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54698-submit@debbugs.gnu.org id=B54698.1649082789598 (code B ref 54698); Mon, 04 Apr 2022 14:34:01 +0000 Original-Received: (at 54698) by debbugs.gnu.org; 4 Apr 2022 14:33:09 +0000 Original-Received: from localhost ([127.0.0.1]:52602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbNlV-00009a-2B for submit@debbugs.gnu.org; Mon, 04 Apr 2022 10:33:09 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:60194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbNlT-00009Q-Uq for 54698@debbugs.gnu.org; Mon, 04 Apr 2022 10:33:08 -0400 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 234EWpQU014842 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 4 Apr 2022 14:32:52 GMT In-Reply-To: <5A577100-75CE-4C9E-A7DA-02B917662AF5@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Sun, 3 Apr 2022 20:40:57 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229412 Archived-At: Mattias Engdeg=C3=A5rd writes: > The GC uses recursion to traverse data structures for marking which > imposes a limit to how big (or deeply nested) Lisp data structures can > be, and usually results in an immediate Emacs crash without warning > when that limit is exceeded. > > The attached patch replaces recursion with an explicit stack for most > common object types: conses, vectors, records, hash tables, symbols, > functions etc. Recursion remains for some less common types (buffers, > frames etc) but these are typically not used in quantities to cause a > problem. > > A side benefit is that GC becomes quite a bit faster as a result. Actual = workloads such as byte-compilation are consequently sped up by a small but = measurable amount. Hi Mattias, do you have any other performance measure for cases different than the one mentioned? Thanks Andrea