From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#41242: Port feature/native-comp to Windows - Determine the emacs root dir... Date: Sat, 30 May 2020 18:51:10 +0000 Message-ID: References: <83k10wshvg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="47569"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 41242@debbugs.gnu.org To: Nicolas =?UTF-8?Q?B=C3=A9rtolo?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 30 20:52:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jf6aX-000CFj-Rr for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 May 2020 20:52:09 +0200 Original-Received: from localhost ([::1]:43676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jf6aW-0003St-DD for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 May 2020 14:52:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jf6aQ-0003Sm-LM for bug-gnu-emacs@gnu.org; Sat, 30 May 2020 14:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47675) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jf6aQ-0003i6-9N for bug-gnu-emacs@gnu.org; Sat, 30 May 2020 14:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jf6aQ-0003WL-7f for bug-gnu-emacs@gnu.org; Sat, 30 May 2020 14:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 May 2020 18:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41242 X-GNU-PR-Package: emacs Original-Received: via spool by 41242-submit@debbugs.gnu.org id=B41242.159086467413478 (code B ref 41242); Sat, 30 May 2020 18:52:02 +0000 Original-Received: (at 41242) by debbugs.gnu.org; 30 May 2020 18:51:14 +0000 Original-Received: from localhost ([127.0.0.1]:59221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf6Ze-0003VJ-3o for submit@debbugs.gnu.org; Sat, 30 May 2020 14:51:14 -0400 Original-Received: from mx.sdf.org ([205.166.94.20]:65093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf6Zc-0003VB-E9 for 41242@debbugs.gnu.org; Sat, 30 May 2020 14:51:13 -0400 Original-Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 04UIpB7A029364 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sat, 30 May 2020 18:51:11 GMT Original-Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 04UIpBb5027153; Sat, 30 May 2020 18:51:11 GMT In-Reply-To: ("Nicolas =?UTF-8?Q?B=C3=A9rtolo?="'s message of "Sat, 30 May 2020 13:25:48 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181255 Archived-At: Nicolas B=C3=A9rtolo writes: > --- > src/comp.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/comp.c b/src/comp.c > index 32a98173d5..310ad76fbe 100644 > --- a/src/comp.c > +++ b/src/comp.c > @@ -4120,7 +4120,12 @@ finish_delayed_disposal_of_comp_units (void) > register_native_comp_unit (Lisp_Object comp_u) > { > #ifdef WINDOWSNT > - Fputhash (CALL1I (gensym, Qnil), comp_u, all_loaded_comp_units_h); > + /* We have to do this since we can't use `gensym'. This function is > + called early when loading a dump file and subr.el may not have > + been loaded yet. */ > + static intmax_t count; > + > + Fputhash(make_int(count++), comp_u, all_loaded_comp_units_h); > #endif > } Again as suggested, *please* run 'check_GNU_style.sh' on your patches if you are not used to GNU code style to fix it. Presenting a patch correctly formatted, well tested and fully understood is a sign of respect for reviewers and the time they are going to invest in the review process. We are all volunteers and we all have to cope with time constraints. Investing time in reviews means subtracting it to other activities including working on other patches and features. We aim for code quality rather then quantity or other metrics. The followings are to be considered as basic features we want for all patches (not just this) to be applied to this branch: - Compiles and bootstrap --with-nativecomp --without-nativecomp - Formatting is correct Obviously we can always make mistakes that is totally okay, but does not have to be a routine that is expected to be fixed by reviewers. Please apply these suggestions to all patches that are submitted or pending for review to speed-up the process so we can leave the discussion for interesting topics. Thanks Andrea --=20 akrl@sdf.org