From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Sun, 14 Mar 2021 19:06:01 +0000 Message-ID: References: <83a6s04glg.fsf@gnu.org> <83k0qzv54q.fsf@gnu.org> <83lfawp2cc.fsf@gnu.org> <83k0qgp0hj.fsf@gnu.org> <837dmfp2x7.fsf@gnu.org> <83v99znizq.fsf@gnu.org> <83o8frnf2r.fsf@gnu.org> <83r1khfy5d.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22297"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 14 20:07:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLW4z-0005hx-E3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Mar 2021 20:07:09 +0100 Original-Received: from localhost ([::1]:34478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLW4y-0008TV-H1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Mar 2021 15:07:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60716) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLW4s-0008Su-Rk for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2021 15:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50905) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lLW4s-0005wC-KA for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2021 15:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lLW4s-0007UJ-Ec for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2021 15:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Mar 2021 19:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.161574876428717 (code B ref 43725); Sun, 14 Mar 2021 19:07:02 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 14 Mar 2021 19:06:04 +0000 Original-Received: from localhost ([127.0.0.1]:34218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLW3w-0007T7-4L for submit@debbugs.gnu.org; Sun, 14 Mar 2021 15:06:04 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:57342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLW3u-0007T0-WA for 43725@debbugs.gnu.org; Sun, 14 Mar 2021 15:06:03 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 12EJ617e012853 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sun, 14 Mar 2021 19:06:02 GMT In-Reply-To: <83r1khfy5d.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 14 Mar 2021 19:22:38 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202384 Archived-At: Eli Zaretskii writes: > Andrea, I see in comp.c and comp.el you many times use 'concat' > instead of expand-file-name to construct a file name from the leading > directories and a basename. Sometimes even a mix of the two. Here's > one example: > > return Fexpand_file_name (filename, > concat2 (Ffile_name_as_directory (base_dir), > Vcomp_native_version_dir)); > > Is there a reason for using 'concat' in these cases? E.g., the above > could be written as > > return Fexpand_file_name (filename > Fexpand_file_name (Vcomp_native_version_dir, > base_dir)); > > which also makes only 2 function calls instead of 3. Am I missing > something? I guess is more likely that *I* missed something here :) Probably in this case I thought that because I've used Ffile_name_as_directory its output could just be concatenated without having to use Fexpand_file_name. Is this practice incorrect or dangerous? Thanks Andrea