From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#48029: 28.1; [native-comp] Function names with non-ascii characters Date: Fri, 08 Jul 2022 13:43:15 +0000 Message-ID: References: <877dkp2zr6.fsf@miha-pc> <874kfliksx.fsf@gnus.org> <87bkua8fga.fsf@gnus.org> <8335fh9lah.fsf@gnu.org> <87bku0g6h7.fsf@gnus.org> <83pmig40s4.fsf@gnu.org> <838rp34w1o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36490"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: larsi@gnus.org, 48029@debbugs.gnu.org, jakanakaevangeli@chiru.no To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 08 15:44:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9oHD-0009KE-OR for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Jul 2022 15:44:11 +0200 Original-Received: from localhost ([::1]:56496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9oHC-0001Va-K6 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Jul 2022 09:44:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9oH4-0001SX-T2 for bug-gnu-emacs@gnu.org; Fri, 08 Jul 2022 09:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37005) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9oH4-0000d8-KT for bug-gnu-emacs@gnu.org; Fri, 08 Jul 2022 09:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9oH4-00045R-Af for bug-gnu-emacs@gnu.org; Fri, 08 Jul 2022 09:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Jul 2022 13:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48029 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 48029-submit@debbugs.gnu.org id=B48029.165728780115608 (code B ref 48029); Fri, 08 Jul 2022 13:44:02 +0000 Original-Received: (at 48029) by debbugs.gnu.org; 8 Jul 2022 13:43:21 +0000 Original-Received: from localhost ([127.0.0.1]:59135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9oGO-00043g-RH for submit@debbugs.gnu.org; Fri, 08 Jul 2022 09:43:21 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:57142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9oGM-00043P-97 for 48029@debbugs.gnu.org; Fri, 08 Jul 2022 09:43:20 -0400 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 268DhFGh023009 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 8 Jul 2022 13:43:15 GMT In-Reply-To: <838rp34w1o.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 08 Jul 2022 15:40:35 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236455 Archived-At: Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: larsi@gnus.org, 48029@debbugs.gnu.org, jakanakaevangeli@chiru.no >> Date: Fri, 08 Jul 2022 08:49:42 +0000 >> >> > Why do we have ";; -*-coding: nil; -*- "? I think that's the problem: >> > it should be ";; -*-coding: utf-8; -*- " instead. Where does the nil >> > come from? >> >> AFAIR at the time we encountered a situation when one of these files was >> read back with some other encoding (I guess it's heuristic?) so fixing >> the encoding to nil solved the issue. > > You mean, bug#45433? Yes that's the one. > If the problem is EOL conversion, using > utf-8-unix instead of utf-8 should take care of that. Or maybe even > use utf-8-emacs-unix. Will utf-8-unix or utf-8-emacs-unix work on every OS? If yes which one would you recommend we use? > Are we likely to write bytecode into this temporary file? Yes definitely >> > Lisp sources are by default UTF-8 encoded, so that should be the >> > default for the temp file we write. Bonus points for using the actual >> > encoding of the Lisp source file there (which in very rare cases can >> > be something other than UTF-8). >> >> Ok attached the patch that sets it to utf-8, seems to work for me. >> >> I'll have a look on how to spill the original coding system and get the >> bonus points hopefully next week. > > Thanks. > >> Should this patch go in master or into the release branch? > > To the release branch, if Lars agrees. But let's first try to see if > bug#45433 is not back after the above change. I can't see the test failing even removing the original fix so probably some of the code in Emacs that is leveraged changed. This also suggests the test is not really useful anymore (I'll double check and remove it). Andrea