unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 47024@debbugs.gnu.org
Cc: eliz@gnu.org
Subject: bug#47024: 28.0.50; [feature/native-comp] Warnings from async compilations truncated
Date: Fri, 12 Mar 2021 09:04:32 +0000	[thread overview]
Message-ID: <xjfv99wpwtb.fsf@sdf.org> (raw)
In-Reply-To: <xjf7dmfrq6m.fsf@sdf.org> (Andrea Corallo via's message of "Wed,  10 Mar 2021 15:20:17 +0000")

Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Andrea Corallo <akrl@sdf.org>
>>> Cc: 47024@debbugs.gnu.org
>>> Date: Wed, 10 Mar 2021 13:12:59 +0000
>>>
>>> >  seq.el:396:16: Warning: `seq-contains' is an obsolete generic function (as of
>>> >      27.1); use `seq-contains-p' instead.
>>> >
>>> > There's an actual newline at the end of the first line, because by
>>> > default we _fill_ the text.
>>> >
>>> > So I think the solution should be to bind (in the sub-process which
>>> > performs the actual compilation) warning-fill-column to a large
>>> > number.
>>>
>>> Nice, is 256 a reasonable number?
>>
>> How about most-positive-fixnum?
>
> Sounds good, fe1c081c38 does that.
>
>>> > Is there a similar issue with error messages?
>>>
>>> Yes, we suffer from the same issue if the Error is emitted with new
>>> lines.
>>
>> But is there a similar variable to bind in that case? fill-column,
>> perhaps?
>
> Dunno, I'll make some tests if we don't get a precise suggestion.

With 0144764d1d error reporting appears to be working for me.

I had no problems with line truncations but I had to tweak the way we
are printing them (before we emitted always the full backtrace) so now
we can parse them and report to the user correctly.

My testcase is to signal and error with a very long message within an
`eval-when-compile' and I see it now reported entirely in the
"*Async-native-compile-log*".

Please let me know if you have some other suggestion on how to test
this.

Thanks

  Andrea





  reply	other threads:[~2021-03-12  9:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 17:47 bug#47024: 28.0.50; [feature/native-comp] Warnings from async compilations truncated Eli Zaretskii
2021-03-09 20:37 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-10  3:24   ` Eli Zaretskii
2021-03-10  6:50     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-10 13:07       ` Eli Zaretskii
2021-03-10 13:12         ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-10 13:51           ` Eli Zaretskii
2021-03-10 15:20             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-12  9:04               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-03-19 14:16                 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-19 14:44                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xjfv99wpwtb.fsf@sdf.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=47024@debbugs.gnu.org \
    --cc=akrl@sdf.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).