From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#46617: 28.0.50; nativecomp: native compile cache is not invalidated when file is re-byte compiled and changes Date: Fri, 26 Mar 2021 07:54:47 +0000 Message-ID: References: Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34945"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Andrew Whatson , 46617@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 26 08:55:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPhJT-0008ww-KO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Mar 2021 08:55:23 +0100 Original-Received: from localhost ([::1]:56044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPhJS-0000Ua-Mg for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Mar 2021 03:55:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPhJ8-0000U9-LR for bug-gnu-emacs@gnu.org; Fri, 26 Mar 2021 03:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56962) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPhJ8-00067P-DV for bug-gnu-emacs@gnu.org; Fri, 26 Mar 2021 03:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lPhJ8-0001nE-6W for bug-gnu-emacs@gnu.org; Fri, 26 Mar 2021 03:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Mar 2021 07:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46617 X-GNU-PR-Package: emacs Original-Received: via spool by 46617-submit@debbugs.gnu.org id=B46617.16167452906865 (code B ref 46617); Fri, 26 Mar 2021 07:55:02 +0000 Original-Received: (at 46617) by debbugs.gnu.org; 26 Mar 2021 07:54:50 +0000 Original-Received: from localhost ([127.0.0.1]:40275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPhIw-0001mf-8N for submit@debbugs.gnu.org; Fri, 26 Mar 2021 03:54:50 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:58886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPhIu-0001mW-Vf for 46617@debbugs.gnu.org; Fri, 26 Mar 2021 03:54:49 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 12Q7slZ7016632 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 26 Mar 2021 07:54:47 GMT In-Reply-To: (Andrea Corallo via's message of "Mon, 22 Mar 2021 07:57:40 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203036 Archived-At: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Aaron Jensen writes: > >> On Sun, Mar 21, 2021 at 3:54 PM Andrea Corallo wrote: >>> >>> Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of >>> text editors" writes: >>> >>> >>> Okay I've added `comp-lookup-eln' son now the user can search if a >>> certain .eln is in reach in `comp-eln-load-path' for a given .el. >>> >>> So now one can use the following to force a native load. >>> >>> (load (comp-lookup-eln ".../foo.el")) >> >> Okay, and that would return nil if it's not native compiled, which >> would be their cue to native compile it, yes? > > Yes `comp-lookup-eln' will return nil if the eln is not found. > >> That's nice to be able >> to force load it. >> >> Without doing the modification date stuff you mentioned or purge >> before byte compile, native compilation ends up having to be a concern >> of anything that's doing byte compiling, which is unfortunate. > > Say anything that's doing byte compiling deliberately capturing > environment values yes. > > Andrea I've reintroduced the file timestamp check on the eln files being loaded with 79b8b6ca45. This should protect us from loading stale eln that captured some stale env during compilation. I'm Ccing Andrew and this was previously discussed in bug#43532, (note now .el and .eln timestamps can now be equal so it should work also for the discussed case in bug#43532). Please let us know if this change is problematic. Thanks Andrea