From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#62004: 30.0.50; comp-run-async-workers failure when default-directory deleted Date: Tue, 07 Mar 2023 16:06:56 +0000 Message-ID: References: <874jqxyhfo.fsf@gmail.com> <83sfeh7rlm.fsf@gnu.org> <87zg8px01l.fsf@gmail.com> <83mt4p7mv4.fsf@gnu.org> <87v8jdww42.fsf@gmail.com> <83jzzt7iac.fsf@gnu.org> <87jzztwo9h.fsf@gmail.com> <83h6ux6xwl.fsf@gnu.org> <831qm07lba.fsf@gnu.org> <83o7p463zt.fsf@gnu.org> <87mt4otw1x.fsf@gmail.com> <87ilfctv36.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36578"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , 62004@debbugs.gnu.org To: No Wayman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 07 17:07:57 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZZr2-0009NF-4d for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Mar 2023 17:07:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZZqC-0006vF-6w; Tue, 07 Mar 2023 11:07:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZZqA-0006rs-MS for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 11:07:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZZqA-0002iT-EF for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 11:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZZqA-0002Ev-1t for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 11:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Mar 2023 16:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62004 X-GNU-PR-Package: emacs Original-Received: via spool by 62004-submit@debbugs.gnu.org id=B62004.16782052218602 (code B ref 62004); Tue, 07 Mar 2023 16:07:02 +0000 Original-Received: (at 62004) by debbugs.gnu.org; 7 Mar 2023 16:07:01 +0000 Original-Received: from localhost ([127.0.0.1]:47031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZZq8-0002Eg-Oz for submit@debbugs.gnu.org; Tue, 07 Mar 2023 11:07:01 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:62654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZZq6-0002EV-Gb for 62004@debbugs.gnu.org; Tue, 07 Mar 2023 11:06:59 -0500 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.16.1/8.14.5) with ESMTPS id 327G6u1A008146 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 7 Mar 2023 16:06:57 GMT In-Reply-To: <87ilfctv36.fsf@gmail.com> (No Wayman's message of "Tue, 07 Mar 2023 10:53:58 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257480 Archived-At: No Wayman writes: > No Wayman writes: > >> Binding default-directory makes sense. >> It's just a matter of what to bind it to. >> I see that `comp-run-async-workers` calls `make-temp-file' >> internally. >> Binding default-directory to temporary-file-directory around the >> call to >> `make-process' will prevent this error and seems like a safe bet. > > The attached patch implements this and fixes the error on my end. >From fd33c2d58ac078ed53cdada5fa6e378e59247a3a Mon Sep 17 00:00:00 2001 > From: Nicholas Vollmer > Date: Tue, 7 Mar 2023 10:44:17 -0500 > Subject: [PATCH] comp.el (comp-run-async-workers): bind default-directory > > Ensure default-directory exists prior to creating subprocess. (bug#62004) > --- > lisp/emacs-lisp/comp.el | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el > index ce81680a226..97cfa27a1aa 100644 > --- a/lisp/emacs-lisp/comp.el > +++ b/lisp/emacs-lisp/comp.el > @@ -4023,6 +4023,7 @@ comp-run-async-workers > (comp-log "\n") > (mapc #'comp-log expr-strings))) > (load1 load) > + (default-directory temporary-file-directory) > (process (make-process > :name (concat "Compiling: " source-file) > :buffer (with-current-buffer If tested LGTM, another option (maybe safer?) would be to use `invocation-directory'. Thanks Andrea