From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#48031: 28.0.50; comp-tests oddities Date: Mon, 26 Apr 2021 16:46:39 +0000 Message-ID: References: <8735vdpeso.fsf@gmx.de> <87h7jtkolq.fsf@gmx.de> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24978"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48031@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 26 18:47:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lb4O9-00068j-Ga for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Apr 2021 18:47:13 +0200 Original-Received: from localhost ([::1]:50382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lb4O8-0000iu-IA for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Apr 2021 12:47:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lb4Ny-0000h3-PZ for bug-gnu-emacs@gnu.org; Mon, 26 Apr 2021 12:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35455) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lb4Ny-0005ye-JZ for bug-gnu-emacs@gnu.org; Mon, 26 Apr 2021 12:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lb4Ny-00086f-GA for bug-gnu-emacs@gnu.org; Mon, 26 Apr 2021 12:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Apr 2021 16:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48031 X-GNU-PR-Package: emacs Original-Received: via spool by 48031-submit@debbugs.gnu.org id=B48031.161945560631129 (code B ref 48031); Mon, 26 Apr 2021 16:47:02 +0000 Original-Received: (at 48031) by debbugs.gnu.org; 26 Apr 2021 16:46:46 +0000 Original-Received: from localhost ([127.0.0.1]:46999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lb4Nh-000861-TZ for submit@debbugs.gnu.org; Mon, 26 Apr 2021 12:46:46 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:63946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lb4Nf-00085q-D5 for 48031@debbugs.gnu.org; Mon, 26 Apr 2021 12:46:44 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 13QGkd2x016134 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 26 Apr 2021 16:46:40 GMT In-Reply-To: <87h7jtkolq.fsf@gmx.de> (Michael Albinus's message of "Mon, 26 Apr 2021 18:16:49 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204960 Archived-At: Michael Albinus writes: > Andrea Corallo writes: > >> Hi Michael, > > Hi Andrea, > >> as of 9d34fd8b33 both issues should be solved, could you have a look if >> it works for you too? > > LGTM. > > Btw, in ert-x.el we have the macros `ert-resource-directory' and > `ert-resource-file'. > > (defconst comp-test-directory (concat (file-name-directory > (or load-file-name > buffer-file-name)) > "comp-tests-resources/")) > > > could be > > (defconst comp-test-directory (ert-resource-directory) > > > (or just be removed), and > > (defconst comp-test-src > (expand-file-name "comp-test-funcs.el" comp-test-directory)) Nice! In this case I guess we have to rename "test/src/comp-tests-resources/" into "test/src/comp-resources/" would this be okay? Thanks Andrea